Skip to content

🌱 Only include ClusterExtensionRevision CRD when Boxcutter enabled - #2331

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:fg-cer-crd
Nov 13, 2025
Merged

🌱 Only include ClusterExtensionRevision CRD when Boxcutter enabled#2331
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:fg-cer-crd

Conversation

@tmshort

@tmshorttmshort commented Nov 13, 2025

Copy link
Copy Markdown
Contributor

Add a check for the BoxcutterRuntime feature-gate before including the ClusterExtensionRevision CRD into the manifest.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort
Only include ClusterExtensionRevision CRD when Boxcutter enabled
aa629d3
Add a check for the BoxcutterRuntime feature-gate before including the
ClusterExtensionRevision CRD into the manifest.
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
tmshort requested a review from a team as a code ownerNovember 13, 2025 14:20
@netlify

netlifyBot commented Nov 13, 2025•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commitaa629d3
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/6915e92594f0e100082aaa10
😎 Deploy Previewhttps://deploy-preview-2331--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecovBot commented Nov 13, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.30%. Comparing base (c95fc24) to head (aa629d3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2331 +/- ##
=======================================
Coverage 74.30% 74.30% =======================================
Files 91 91 Lines 7083 7083 =======================================
Hits 5263 5263 Misses 1405 1405 Partials 415 415
FlagCoverage Δ
e2e45.69% <ø> (+0.04%)⬆️
experimental-e2e48.35% <ø> (ø)
unit58.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

perdasilva
perdasilva reviewed Nov 13, 2025
View reviewed changes

@perdasilvaperdasilva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve thanks for this!

@openshift-ci

openshift-ciBot commented Nov 13, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2025
anik120
anik120 reviewed Nov 13, 2025
View reviewed changes

@anik120anik120 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2025
@openshift-merge-bot
openshift-merge-botBot merged commit c06f27f into operator-framework:mainNov 13, 2025
27 of 29 checks passed
@tmshort
tmshort deleted the fg-cer-crd branch November 19, 2025 15:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@perdasilvaperdasilvaperdasilva left review comments
@bentitobentitoAwaiting requested review from bentito
@joelanfordjoelanfordAwaiting requested review from joelanford
+1 more reviewer
@anik120anik120anik120 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@anik120anik120

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tmshort@perdasilva@anik120