Uh oh!
There was an error while loading. Please reload this page.
🐛 OPRUN-4266: Restore last-applied-config annotation in cache - #2338
Merged
openshift-merge-bot[bot] merged 1 commit intoNov 17, 2025
Merged
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
camilamacedo86
approved these changes
Nov 17, 2025
camilamacedo86
left a comment
Contributor
There was a problem hiding this comment.
We are just reverting.
Ok. That is fine 👍
camilamacedo86
commented
Nov 17, 2025
Contributor
/lgtm cancel Seems that is more than a revert. |
This restores the last-applied-config annotation in the cache, as its absense can cause issues with clients when we update our finalizers. This increases memory utilization until we can solve the finalizer issue. Signed-off-by: Todd Short <tshort@redhat.com>
tmshortforce-pushed
the
restore-last-applied-config
branch
from
November 17, 2025 15:25
e3dbec6 to
cdaadc5CompareCodecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #2338 +/- ##
==========================================
- Coverage 74.30% 74.27% -0.03%
==========================================
Files 91 91 Lines 7083 7196 +113 ==========================================
+ Hits 5263 5345 +82 - Misses 1405 1426 +21 - Partials 415 425 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tmshort
commented
Nov 17, 2025
ContributorAuthor
@camilamacedo86 it is now just the revert, and it passing unit tests. |
camilamacedo86
approved these changes
Nov 17, 2025
tmshort
commented
Nov 17, 2025
ContributorAuthor
Two other's LGTM'd |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankitathomas, camilamacedo86, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-botBot
merged commit Nov 17, 2025
39cbdbe
into
operator-framework:main
27 checks passed
Uh oh!
There was an error while loading. Please reload this page.
tmshort added a commit
to tmshort/operator-controller
that referenced
this pull request
Nov 18, 2025
…mework#2338)" This reverts commit 39cbdbe.
tmshort added a commit
to tmshort/operator-controller
that referenced
this pull request
Nov 19, 2025
…mework#2338)" This reverts commit 39cbdbe.
tmshort added a commit
to tmshort/operator-controller
that referenced
this pull request
Nov 19, 2025
…mework#2338)" This reverts commit 39cbdbe.
tmshort added a commit
to tmshort/operator-controller
that referenced
this pull request
Nov 24, 2025
…mework#2338)" This reverts commit 39cbdbe.
tmshort added a commit
to tmshort/operator-controller
that referenced
this pull request
Nov 25, 2025
…mework#2338)" This reverts commit 39cbdbe.
tmshort added a commit
to tmshort/operator-controller
that referenced
this pull request
Nov 26, 2025
…mework#2338)" This reverts commit 39cbdbe.
tmshort added a commit
to tmshort/operator-controller
that referenced
this pull request
Dec 1, 2025
…mework#2338)" This reverts commit 39cbdbe.
openshift-merge-botBot
pushed a commit
that referenced
this pull request
Dec 2, 2025
* Use Patch instead of Update for finalizer operations Refactor all controllers to use Patch() instead of Update() when adding or removing finalizers to improve performance, and to avoid removing non-cached fields erroneously. This is necesary because we no longer cache the last-applied-configuration annotation, so when we add/remove the finalizers, we are removing that field from the metadata. This causes issues with clients when they don't see that annotation (e.g. apply the same ClusterExtension twice). Update ClusterCatalog and ClusterExtension controllers to use Patch-based funalizer management (ClusterExtensionRevision already uses Patch()) Signed-off-by: Todd Short <tshort@redhat.com> * Revert "Restore last-applied-config annotation in cache (#2338)" This reverts commit 39cbdbe. --------- Signed-off-by: Todd Short <tshort@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores the last-applied-config annotation in the cache, as its absense can cause issues with clients when we update our finalizers.
This increases memory utilization until we can solve the finalizer issue.
This removes optimizations from #2290, and is an alternative to #2328.
If #2328 can updated to work (possibly w/o SSA), then this would be reverted to restore the memory savings.
Description
Reviewer Checklist