Skip to content

🐛 Downgrade bingo output files to v0.9.0 - #2343

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:bingo-0.9.0
Nov 18, 2025
Merged

🐛 Downgrade bingo output files to v0.9.0#2343
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:bingo-0.9.0

Conversation

@tmshort

@tmshorttmshort commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

The latest bingo files were generated with bingo v0.10.0, which requires golang 1.24.9, which we don't support.

Downgrade the output files via bingo v0.9.0

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort
tmshort requested a review from a team as a code ownerNovember 18, 2025 14:50
@netlify

netlifyBot commented Nov 18, 2025•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commite1dea12
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/691c9f8df422c70008b90c50
😎 Deploy Previewhttps://deploy-preview-2343--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

camilamacedo86
camilamacedo86 approved these changes Nov 18, 2025
View reviewed changes

@camilamacedo86camilamacedo86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 18, 2025
@openshift-ciopenshift-ciBot removed the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2025
camilamacedo86
camilamacedo86 approved these changes Nov 18, 2025
View reviewed changes

@camilamacedo86camilamacedo86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2025
@codecov

codecovBot commented Nov 18, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.25%. Comparing base (697f392) to head (e1dea12).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2343 +/- ##
===========================================
+ Coverage 55.97% 74.25% +18.27% 
===========================================
Files 82 91 +9 Lines 6547 7198 +651 ===========================================
+ Hits 3665 5345 +1680 + Misses 2367 1426 -941 + Partials 515 427 -88
FlagCoverage Δ
e2e44.57% <ø> (+0.01%)⬆️
experimental-e2e48.51% <ø> (ø)
unit58.44% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ciopenshift-ciBot removed the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2025
camilamacedo86
camilamacedo86 approved these changes Nov 18, 2025
View reviewed changes

@camilamacedo86camilamacedo86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2025
@openshift-ciopenshift-ciBot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 18, 2025
@tmshort
tmshortforce-pushed the bingo-0.9.0 branch 5 times, most recently from d3cdfb3 to e2707cbCompareNovember 18, 2025 16:25
@tmshort
Downgrade bingo output files to v0.9.0
e1dea12
The latest bingo files were generated with bingo v0.10.0, which requires
golang 1.24.9, which we don't support.
Downgrade the output files via bingo v0.9.0
Add test to ensure correct version of bingo is used.
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort

tmshort commented Nov 18, 2025

Copy link
Copy Markdown
ContributorAuthor

@camilamacedo86 this is ready now... there was a timeout issue in bingo CI that was giving me a headache.

@camilamacedo86

camilamacedo86 commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2025
@perdasilva

perdasilva commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ciBot commented Nov 18, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2025
@openshift-merge-bot
openshift-merge-botBot merged commit 6ef62de into operator-framework:mainNov 18, 2025
25 checks passed
@tmshort
tmshort deleted the bingo-0.9.0 branch November 18, 2025 18:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamacedo86camilamacedo86camilamacedo86 approved these changes
@ankitathomasankitathomasAwaiting requested review from ankitathomas
@trgeigertrgeigerAwaiting requested review from trgeiger

Assignees

@camilamacedo86camilamacedo86

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tmshort@camilamacedo86@perdasilva