Skip to content

🌱 Update approvers - #2369

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
perdasilva:update-approvers-list
Dec 3, 2025
Merged

🌱 Update approvers#2369
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
perdasilva:update-approvers-list

Conversation

@perdasilva

Copy link
Copy Markdown
Contributor

Description

Add Catherine, Jordan, and Predrag to our approvers list

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Per G. da Silva <pegoncal@redhat.com>
CopilotAI review requested due to automatic review settings December 3, 2025 14:50
@perdasilva
perdasilva requested a review from a team as a code ownerDecember 3, 2025 14:50
@netlify

netlifyBot commented Dec 3, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit0b3e713
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/69304e3c70c37b00089dc03c
😎 Deploy Previewhttps://deploy-preview-2369--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the OWNERS_ALIASES file to promote three existing reviewers (Catherine/grokspawn, Jordan/oceanc80, and Predrag/pedjak) to the olmv1-approvers list. These individuals were already part of the olmv1-reviewers group and are now being granted approver permissions.

  • Adds three new approvers to the olmv1-approvers alias list
  • Maintains alphabetical ordering of the approvers list
  • Promotes existing reviewers to approver status

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecovBot commented Dec 3, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.52%. Comparing base (4e349e6) to head (0b3e713).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2369 +/- ##
==========================================
+ Coverage 70.61% 74.52% +3.90% 
==========================================
Files 95 95 Lines 7375 7375 ==========================================
+ Hits 5208 5496 +288 + Misses 1728 1440 -288 
Partials 439 439 
FlagCoverage Δ
e2e44.67% <ø> (+0.02%)⬆️
experimental-e2e48.88% <ø> (?)
unit58.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rashmigottipatirashmigottipati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2025
@tmshort

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rashmigottipati, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2025
@openshift-merge-bot
openshift-merge-botBot merged commit c85bc55 into operator-framework:mainDec 3, 2025
32 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@perdasilva@tmshort@rashmigottipati