Skip to content

🐛 Revert "add PDB to make sure at least 1 pod is always available durin… - #2370

Closed
tmshort wants to merge 1 commit into
operator-framework:mainfrom
tmshort:revert
Closed

🐛 Revert "add PDB to make sure at least 1 pod is always available durin…#2370
tmshort wants to merge 1 commit into
operator-framework:mainfrom
tmshort:revert

Conversation

@tmshort

@tmshorttmshort commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

…g upgrade (#2362)"

This is causing an issue with multi-node upgrades downstream.

This reverts commit 5ed8cf4.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort
Revert "add PDB to make sure at least 1 pod is always available durin…
06aaa45
…g upgrade (operator-framework#2362)"
This is causing an issue with multi-node upgrades downstream.
This reverts commit 5ed8cf4.
@tmshort
tmshort requested a review from a team as a code ownerDecember 3, 2025 18:18
@openshift-ci

openshift-ciBot commented Dec 3, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign camilamacedo86 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tmshorttmshort changed the title Revert "add PDB to make sure at least 1 pod is always available durin…🐛 Revert "add PDB to make sure at least 1 pod is always available durin…Dec 3, 2025
@tmshort

tmshort commented Dec 3, 2025

Copy link
Copy Markdown
ContributorAuthor

/hold

@netlify

netlifyBot commented Dec 3, 2025•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit06aaa45
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/69307eef03a86b00084501a6
😎 Deploy Previewhttps://deploy-preview-2370--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ciopenshift-ciBot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2025
@codecov

codecovBot commented Dec 3, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.54%. Comparing base (4e349e6) to head (06aaa45).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2370 +/- ##
==========================================
+ Coverage 70.61% 74.54% +3.93% 
==========================================
Files 95 95 Lines 7375 7375 ==========================================
+ Hits 5208 5498 +290 + Misses 1728 1439 -289 + Partials 439 438 -1
FlagCoverage Δ
e2e44.58% <ø> (-0.06%)⬇️
experimental-e2e48.91% <ø> (?)
unit58.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort

tmshort commented Dec 4, 2025

Copy link
Copy Markdown
ContributorAuthor

Closing, as it's not needed.

@tmshorttmshort closed this Dec 4, 2025
@tmshort
tmshort deleted the revert branch December 4, 2025 14:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OchiengEdOchiengEdAwaiting requested review from OchiengEd
@pedjakpedjakAwaiting requested review from pedjak

Assignees

No one assigned

Labels

do-not-merge/holdIndicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tmshort