Skip to content

⚠️ Remove Paused ClusterExtensionRevision LifecycleState - #2373

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
perdasilva:cer-remove-paused
Dec 5, 2025
Merged

⚠️ Remove Paused ClusterExtensionRevision LifecycleState#2373
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
perdasilva:cer-remove-paused

Conversation

@perdasilva

Copy link
Copy Markdown
Contributor

Description

Removes references from the ClusterExtensionRevision Paused lifecycle state, since we don't plan on including it for now

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
CopilotAI review requested due to automatic review settings December 4, 2025 16:53
@perdasilva
perdasilva requested a review from a team as a code ownerDecember 4, 2025 16:53
@netlify

netlifyBot commented Dec 4, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit0d98698
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/6931bca81f1ff60008069dea
😎 Deploy Previewhttps://deploy-preview-2373--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the "Paused" lifecycle state from the ClusterExtensionRevision API, simplifying the lifecycle model to only support "Active" and "Archived" states. The removal is comprehensive, eliminating the constant definition, related controller logic, and boxcutter integration code.

  • Removed the ClusterExtensionRevisionLifecycleStatePaused constant and its documentation
  • Removed controller logic that handled paused state (boxcutter WithPaused option)
  • Simplified revision filtering logic to only skip archived revisions

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

FileDescription
api/v1/clusterextensionrevision_types.goRemoved the ClusterExtensionRevisionLifecycleStatePaused constant and its documentation
internal/operator-controller/controllers/clusterextensionrevision_controller.goRemoved the conditional logic that added boxcutter.WithPaused option for paused revisions
internal/operator-controller/controllers/boxcutter_reconcile_steps.goSimplified from a switch statement to a simple conditional check, now only skipping archived revisions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecovBot commented Dec 4, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.86%. Comparing base (d44cbaf) to head (0d98698).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2373 +/- ##
==========================================
+ Coverage 72.26% 74.86% +2.60% 
==========================================
Files 95 95 Lines 7336 7332 -4 ==========================================
+ Hits 5301 5489 +188 + Misses 1631 1409 -222 - Partials 404 434 +30 
FlagCoverage Δ
e2e44.88% <0.00%> (?)
experimental-e2e49.29% <100.00%> (-0.04%)⬇️
unit58.85% <0.00%> (+0.03%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pedjakpedjak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 5, 2025

@rashmigottipatirashmigottipati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pedjak, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@perdasilva

Copy link
Copy Markdown
ContributorAuthor

/override go-apidiff

@openshift-ci

Copy link
Copy Markdown

@perdasilva: Overrode contexts on behalf of perdasilva: go-apidiff

Details

In response to this:

/override go-apidiff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot
openshift-merge-botBot merged commit 8176ce2 into operator-framework:mainDec 5, 2025
33 of 34 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@perdasilva@pedjak@rashmigottipati