Skip to content

⚠️ Remove Migrated reason from ClusterExtensionRevision Available condition - #2374

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
perdasilva:cer-remove-migrated
Dec 5, 2025
Merged

⚠️ Remove Migrated reason from ClusterExtensionRevision Available condition#2374
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
perdasilva:cer-remove-migrated

Conversation

@perdasilva

Copy link
Copy Markdown
Contributor

Description

Removes the Migrated reason from the ClusterExtensionRevision Available condition. It would be short-lived and it makes more sense to let the revision controller set the conditions. If there is need to call out migration, we could set an annotation on the revision resource.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
CopilotAI review requested due to automatic review settings December 4, 2025 16:59
@perdasilva
perdasilva requested a review from a team as a code ownerDecember 4, 2025 16:59
@netlify

netlifyBot commented Dec 4, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit7643dc4
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/6931bdef18f6e30008c14e04
😎 Deploy Previewhttps://deploy-preview-2374--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the transient "Migrated" reason from the ClusterExtensionRevision Available condition during storage migration from Helm to ClusterExtensionRevision. The change simplifies the migration flow by allowing the revision controller to manage all condition states uniformly, rather than having the migrator set a short-lived condition.

  • Removed the ClusterExtensionRevisionReasonMigrated constant from the API types
  • Eliminated status condition update code in the migration flow that set Available=Unknown with reason "Migrated"
  • Simplified the BoxcutterStorageMigrator.Migrate() method by removing the post-creation status update logic

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

FileDescription
api/v1/clusterextensionrevision_types.goRemoved the unused ClusterExtensionRevisionReasonMigrated constant from condition reasons
internal/operator-controller/applier/boxcutter.goRemoved code that sets Available=Unknown status condition after creating a migrated revision, along with the subsequent status update and re-fetch operations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecovBot commented Dec 4, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.81%. Comparing base (d44cbaf) to head (7643dc4).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2374 +/- ##
==========================================
+ Coverage 72.26% 74.81% +2.55% 
==========================================
Files 95 95 Lines 7336 7327 -9 ==========================================
+ Hits 5301 5482 +181 + Misses 1631 1410 -221 - Partials 404 435 +31 
FlagCoverage Δ
e2e44.91% <ø> (?)
experimental-e2e49.33% <ø> (+<0.01%)⬆️
unit58.79% <ø> (-0.03%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pedjakpedjak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2025
@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pedjak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2025
@perdasilva

Copy link
Copy Markdown
ContributorAuthor

/override go-apidiff

@openshift-ci

Copy link
Copy Markdown

@perdasilva: Overrode contexts on behalf of perdasilva: go-apidiff

Details

In response to this:

/override go-apidiff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot
openshift-merge-botBot merged commit d8fcdd9 into operator-framework:mainDec 5, 2025
33 of 34 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@perdasilva@pedjak