Uh oh!
There was an error while loading. Please reload this page.
🌱 Fix import linting rule for moved util package - #2378
Conversation
Update .golangci.yaml to reflect that util package is now at internal/shared/util (not internal/util), and update all imports to comply with the linting rule.
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR updates the import linting rule in .golangci.yaml to reflect that the util package has been moved from internal/util to internal/shared/util. The changes ensure all imports comply with the updated linting rule, which enforces an alias naming pattern where packages under internal/shared/util/ are imported with the suffix util appended to the package name.
Key changes:
- Updated
.golangci.yamlregex pattern to match the new package path structure - Renamed package
testutilstotestininternal/shared/util/test/directory - Updated all test file imports to use the new alias
testutil(following the${packagename}utilconvention) - Updated feature gate utility imports to use the longer alias
featuregatesutil(instead offgutil)
Reviewed changes
Copilot reviewed 14 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.golangci.yaml | Updated import linting regex pattern from internal/util/ to internal/shared/util/ |
internal/shared/util/test/utils.go | Changed package declaration from testutils to test |
internal/shared/util/test/summary.go | Changed package declaration from testutils to test |
internal/shared/util/test/artifacts.go | Changed package declaration from testutils to test |
internal/shared/util/test/templates/*.tmpl | Added template files to the new package directory |
internal/operator-controller/features/features.go | Updated import alias from fgutil to featuregatesutil |
internal/catalogd/features/features.go | Updated import alias from fgutil to featuregatesutil |
test/e2e/*.go | Updated imports from utils "...testutils" to testutil "...test" |
test/upgrade-e2e/post_upgrade_test.go | Updated import from utils "...testutils" to testutil "...test" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #2378 +/- ##
==========================================
- Coverage 74.86% 72.85% -2.02%
==========================================
Files 95 98 +3 Lines 7377 7581 +204 ==========================================
Hits 5523 5523 - Misses 1419 1623 +204
Partials 435 435
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva, rashmigottipati The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pedjak
commented
Dec 11, 2025
This PR is just about consolidating import aliases, hence it is strange that codecov reports drop in coverage. /override codecov/project |
@pedjak: Overrode contexts on behalf of pedjak: codecov/project DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
0240528
into
operator-framework:mainUh oh!
There was an error while loading. Please reload this page.
Description
Update .golangci.yaml to reflect that util package is now at internal/shared/util (not internal/util), and update all imports to comply with the linting rule.
Reviewer Checklist