Skip to content

🌱 Move the kind configs into a subdirectory - #2384

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:move-kind-configs
Dec 12, 2025
Merged

🌱 Move the kind configs into a subdirectory#2384
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:move-kind-configs

Conversation

@tmshort

@tmshorttmshort commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

I meant for this to be part of #2382

Rather than litter the root directory with kind configs, add them to a subdirectory.
Also rename the experimental one to indicate it's for 2 nodes.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort
Move the kind configs into a subdirectory
955fc61
Rather than litter the root directory with kind configs, add them to
a subdirectory.
Also rename the experimental one to indicate it's for 2 nodes.
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
tmshort requested a review from a team as a code ownerDecember 12, 2025 16:46
@netlify

netlifyBot commented Dec 12, 2025•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit955fc61
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/693c46d4ec9fe000085830bd
😎 Deploy Previewhttps://deploy-preview-2384--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

pedjak
pedjak reviewed Dec 12, 2025
View reviewed changes

@pedjakpedjak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

rashmigottipati
rashmigottipati approved these changes Dec 12, 2025
View reviewed changes

@rashmigottipatirashmigottipati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2025
@pedjak

pedjak commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ciBot commented Dec 12, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pedjak, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2025
@openshift-merge-bot
openshift-merge-botBot merged commit 87b2a72 into operator-framework:mainDec 12, 2025
24 checks passed
@codecov

codecovBot commented Dec 12, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.05%. Comparing base (841cbde) to head (955fc61).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2384 +/- ##
==========================================
+ Coverage 70.50% 73.05% +2.55% 
==========================================
Files 100 100 Lines 7641 7641 ==========================================
+ Hits 5387 5582 +195 + Misses 1847 1623 -224 - Partials 407 436 +29
FlagCoverage Δ
e2e44.73% <ø> (?)
experimental-e2e49.37% <ø> (+0.02%)⬆️
unit57.11% <ø> (+0.01%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort
tmshort deleted the move-kind-configs branch December 12, 2025 18:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedjakpedjakpedjak left review comments
@rashmigottipatirashmigottipatirashmigottipati approved these changes
@oceanc80oceanc80Awaiting requested review from oceanc80
@OchiengEdOchiengEdAwaiting requested review from OchiengEd

Assignees

@pedjakpedjak

@rashmigottipatirashmigottipati

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tmshort@pedjak@rashmigottipati