Skip to content

🌱 Improve Makefile error handling and fix policy message typos - #2402

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
pedjak:follow-up-pr-2393
Jan 2, 2026
Merged

🌱 Improve Makefile error handling and fix policy message typos#2402
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
pedjak:follow-up-pr-2393

Conversation

@pedjak

@pedjakpedjak commented Dec 22, 2025

Copy link
Copy Markdown
Contributor

Followup of PR #2393

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@pedjak
pedjak requested a review from a team as a code ownerDecember 22, 2025 20:12
@netlify

netlifyBot commented Dec 22, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commitb7fcacd
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/6949a61784c8f50008dc6bda
😎 Deploy Previewhttps://deploy-preview-2402--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pedjakpedjak changed the title Fix unaddressed comments on PR #2393🌱 Fix unaddressed comments on PR #2393Dec 22, 2025
@pedjakpedjak changed the title 🌱 Fix unaddressed comments on PR #2393🌱 Fix unaddressed comments on PR #2393Dec 22, 2025
@codecov

codecovBot commented Dec 22, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.05%. Comparing base (08436e0) to head (b7fcacd).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2402 +/- ##
==========================================
+ Coverage 73.00% 73.05% +0.05% 
==========================================
Files 100 100 Lines 7641 7641 ==========================================
+ Hits 5578 5582 +4 - Misses 1625 1626 +1 + Partials 438 433 -5 
FlagCoverage Δ
e2e43.90% <ø> (+0.11%)⬆️
experimental-e2e48.63% <ø> (-0.06%)⬇️
unit57.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@camilamacedo86camilamacedo86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2025
@pedjakpedjak changed the title 🌱 Fix unaddressed comments on PR #2393🌱 Improve Makefile error handling and fix policy message typosJan 2, 2026

@rashmigottipatirashmigottipati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2026
@openshift-merge-bot
openshift-merge-botBot merged commit a6296ab into operator-framework:mainJan 2, 2026
27 of 31 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pedjak@rashmigottipati@camilamacedo86