Skip to content

🐛 Fix API documentation to comply with k8s conventions by fixing embedded field docs and adding missing +optional markers - #2409

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
camilamacedo86:fix-go-docs-linter-api-check
Jan 6, 2026
Merged

🐛 Fix API documentation to comply with k8s conventions by fixing embedded field docs and adding missing +optional markers#2409
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
camilamacedo86:fix-go-docs-linter-api-check

Conversation

@camilamacedo86

@camilamacedo86camilamacedo86 commented Dec 24, 2025

Copy link
Copy Markdown
Contributor

Description

  • Updated API documentation comments to conform to Kubernetes API conventions.
  • Fixed documentation for embedded fields (e.g., ObjectMeta) so they render correctly in generated API docs.
  • Added missing +optional markers to API fields to satisfy kube-api-linter requirements.

PS.: No functional or behavioral changes; documentation and API metadata only.

TL'DR

=== FIXED ISSUES ===
api/v1/clusterextension_types.go:477:2:kubeapilinter:commentstart: godoc for field ClusterExtensionStatus.Conditions should start with 'conditions ...'
api/v1/clusterextension_types.go:540:2:kubeapilinter:commentstart: field ClusterExtension.metav1.ObjectMeta is missing godoc comment
api/v1/clusterextensionrevision_types.go:219:2:kubeapilinter:commentstart: field ClusterExtensionRevision.metav1.ObjectMeta is missing godoc comment
=== HOW ===
1. api/v1/clusterextension_types.go:477 - ClusterExtensionStatus.Conditions godoc formatting
Fixed godoc comment to start with 'conditions' instead of custom text
2. api/v1/clusterextension_types.go:540 - ClusterExtension.metav1.ObjectMeta missing godoc
Added godoc comment for the embedded ObjectMeta field
3. api/v1/clusterextensionrevision_types.go:219 - ClusterExtensionRevision.metav1.ObjectMeta missing godoc
Added godoc comment for the embedded ObjectMeta field

CopilotAI review requested due to automatic review settings December 24, 2025 11:04
@camilamacedo86
camilamacedo86 requested a review from a team as a code ownerDecember 24, 2025 11:04
@netlify

netlifyBot commented Dec 24, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit2954109
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/694bc8ca4e7a930008467652
😎 Deploy Previewhttps://deploy-preview-2409--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@camilamacedo86camilamacedo86 changed the title (fix) Api documentation📖 (fix) Api documentationDec 24, 2025
@camilamacedo86camilamacedo86 changed the title 📖 (fix) Api documentation📖 (fix) Api documentation kube-api-linter checkDec 24, 2025
@camilamacedo86camilamacedo86 changed the title 📖 (fix) Api documentation kube-api-linter check🐛 (fix) Api documentation kube-api-linter checkDec 24, 2025

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the API documentation for ClusterExtension-related resources by adding introductory descriptions to key fields. The changes improve clarity by providing context at the start of field documentation before diving into detailed specifications.

Key changes:

  • Added introductory documentation to the conditions field in ClusterExtensionStatus explaining it represents the current state
  • Added standard metadata field documentation to ClusterExtension and ClusterExtensionRevision types

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
api/v1/clusterextension_types.goAdded documentation for the conditions field and metadata field in ClusterExtension type
api/v1/clusterextensionrevision_types.goAdded standard metadata field documentation to ClusterExtensionRevision type
manifests/standard.yamlUpdated CRD with conditions field documentation
manifests/standard-e2e.yamlUpdated e2e manifest with conditions field documentation
manifests/experimental.yamlUpdated experimental CRD with conditions field documentation
manifests/experimental-e2e.yamlUpdated experimental e2e manifest with conditions field documentation
helm/olmv1/base/operator-controller/crd/standard/olm.operatorframework.io_clusterextensions.yamlUpdated standard helm CRD with conditions field documentation
helm/olmv1/base/operator-controller/crd/experimental/olm.operatorframework.io_clusterextensions.yamlUpdated experimental helm CRD with conditions field documentation
docs/api-reference/olmv1-api-reference.mdUpdated API reference documentation to include the new introductory text for conditions field

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@camilamacedo86camilamacedo86 changed the title 🐛 (fix) Api documentation kube-api-linter check🐛 (fix) API documentation to comply with k8s conventions by fixing embedded field docs and adding missing +optional markersDec 24, 2025
@codecov

codecovBot commented Dec 24, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.06%. Comparing base (578dc33) to head (2954109).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2409 +/- ##
==========================================
+ Coverage 68.82% 73.06% +4.24% 
==========================================
Files 100 100 Lines 7641 7641 ==========================================
+ Hits 5259 5583 +324 + Misses 1947 1621 -326 - Partials 435 437 +2 
FlagCoverage Δ
e2e44.01% <ø> (+0.07%)⬆️
experimental-e2e48.68% <ø> (+35.00%)⬆️
unit57.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@camilamacedo86camilamacedo86 changed the title 🐛 (fix) API documentation to comply with k8s conventions by fixing embedded field docs and adding missing +optional markers🐛 Fix API documentation to comply with k8s conventions by fixing embedded field docs and adding missing +optional markersDec 24, 2025

@pedjakpedjak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2026
@camilamacedo86

Copy link
Copy Markdown
ContributorAuthor

@tmshort could you please help us to bypass the crd-diff in this case?

@tmshort

Copy link
Copy Markdown
Contributor

/approve

@tmshorttmshort reopened this Jan 5, 2026
@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2026
@tmshort

Copy link
Copy Markdown
Contributor

/override crd-diff

@openshift-ci

Copy link
Copy Markdown

@tmshort: Overrode contexts on behalf of tmshort: crd-diff

Details

In response to this:

/override crd-diff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tmshort

Copy link
Copy Markdown
Contributor

/override crd-diff/crd-diff

@openshift-ci

Copy link
Copy Markdown

@tmshort: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • crd-diff/crd-diff

Only the following failed contexts/checkruns were expected:

  • Autovalidate
  • Verify PR title
  • crd-diff
  • e2e
  • experimental-e2e
  • extension-developer-e2e
  • go-apidiff
  • go-verdiff
  • goreleaser
  • lint
  • netlify/olmv1/deploy-preview
  • st2ex-e2e
  • tide
  • unit-test-basic
  • upgrade-st2st-e2e
  • verify

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override crd-diff/crd-diff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@grokspawngrokspawn reopened this Jan 6, 2026
@openshift-merge-bot
openshift-merge-botBot merged commit 5d85feb into operator-framework:mainJan 6, 2026
84 of 88 checks passed
@camilamacedo86
camilamacedo86 deleted the fix-go-docs-linter-api-check branch January 7, 2026 09:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@camilamacedo86@tmshort@pedjak@grokspawn