Skip to content

🌱 standardizing approach for required-tests-with-occasional-overrides - #2431

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
grokspawn:required-actions-overrides
Jan 7, 2026
Merged

🌱 standardizing approach for required-tests-with-occasional-overrides#2431
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
grokspawn:required-actions-overrides

Conversation

@grokspawn

Copy link
Copy Markdown
Contributor

Description

Updates the go-ver-diff and crd-diff tests to follow a standardized approach where they examine labels on the PR to override against failures. This provides the ability for good override capture for required tests (which we want occasionally to override) in a context where having GH handles the tests and prow handles the merges doesn't include the ability for prow to override GH tests.
In this case, creation and application of a label of the form <workflow-name>-override on the PR will allow the test to fail but record the override for prosperity.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

CopilotAI review requested due to automatic review settings January 6, 2026 22:06
@grokspawn
grokspawn requested a review from a team as a code ownerJanuary 6, 2026 22:06
@netlify

netlifyBot commented Jan 6, 2026

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit54109b1
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/695d8af7681ca50008dc5c3c
😎 Deploy Previewhttps://deploy-preview-2431--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes the approach for handling test overrides in required CI workflows by moving the override logic from shell scripts to GitHub Actions workflow steps. The change enables users to apply labels like go-verdiff-override or crd-diff-override to PRs to bypass test failures while maintaining a record of the override.

Key Changes:

  • Moved override checking logic from bash scripts to GitHub Actions workflow files
  • Implemented a two-step pattern: run the test with error continuation, then check for override labels
  • Standardized the override label naming convention to <workflow-name>-override

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

FileDescription
hack/tools/check-go-version.shRemoved override label checking logic and LABELS environment variable handling from the shell script
.github/workflows/go-verdiff.yamlAdded separate step for checking override labels with proper error handling and environment configuration
.github/workflows/crd-diff.yamlAdded override label checking step following the same pattern as go-verdiff workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread.github/workflows/go-verdiff.yaml Outdated
Comment thread.github/workflows/crd-diff.yaml
Comment thread.github/workflows/go-verdiff.yaml
Comment thread.github/workflows/crd-diff.yaml
@grokspawn
grokspawnforce-pushed the required-actions-overrides branch from b72e84a to 208d638CompareJanuary 6, 2026 22:12
CopilotAI review requested due to automatic review settings January 6, 2026 22:15
@grokspawn
grokspawnforce-pushed the required-actions-overrides branch from 208d638 to fc9de18CompareJanuary 6, 2026 22:15

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread.github/workflows/go-verdiff.yaml Outdated
Comment thread.github/workflows/crd-diff.yaml Outdated
Signed-off-by: grokspawn <jordan@nimblewidget.com>
@grokspawn
grokspawnforce-pushed the required-actions-overrides branch from fc9de18 to 54109b1CompareJanuary 6, 2026 22:21
@tmshort

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2026
@codecov

codecovBot commented Jan 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.96%. Comparing base (bcb3d07) to head (54109b1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2431 +/- ##
==========================================
- Coverage 73.05% 72.96% -0.10% 
==========================================
Files 100 100 Lines 7641 7641 ==========================================
- Hits 5582 5575 -7 - Misses 1623 1630 +7 
Partials 436 436 
FlagCoverage Δ
e2e46.85% <ø> (ø)
experimental-e2e48.49% <ø> (-0.26%)⬇️
unit57.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oceanc80oceanc80 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rashmigottipatirashmigottipati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@grokspawn

Copy link
Copy Markdown
ContributorAuthor

/approve

@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2026
@openshift-merge-bot
openshift-merge-botBot merged commit 25aa763 into operator-framework:mainJan 7, 2026
38 of 41 checks passed
@grokspawn
grokspawn deleted the required-actions-overrides branch January 7, 2026 03:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@grokspawn@tmshort@rashmigottipati@oceanc80