Uh oh!
There was an error while loading. Please reload this page.
✨Extract and pass deploymentConfig to bundle renderer - #2482
Merged
anik120 merged 1 commit intoFeb 3, 2026
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
anik120
requested review from
perdasilva and tmshort
and removed request for
pedjak and thetechnickFebruary 3, 2026 17:10
Contributor
There was a problem hiding this comment.
Pull request overview
This PR completes Phase 3 of the Deployment Configuration RFC, enabling users to customize operator deployments through the ClusterExtension spec. It extracts validated deploymentConfig from the bundle configuration and passes it to the renderer for application to operator deployments.
Changes:
- Added extraction logic to get
deploymentConfigfrom validated bundle configuration - Implemented conversion from map to
DeploymentConfigstruct via JSON marshaling - Added comprehensive test coverage for various deploymentConfig scenarios
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/operator-controller/applier/provider.go | Added deploymentConfig extraction and conversion logic in Get method; implemented convertToDeploymentConfig helper function |
| internal/operator-controller/applier/provider_test.go | Added 4 test cases covering deploymentConfig with single field, no config, multiple fields, and combination with watchNamespace |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #2482 +/- ##
==========================================
- Coverage 73.73% 69.76% -3.97%
==========================================
Files 102 102 Lines 8451 8473 +22 ==========================================
- Hits 6231 5911 -320 - Misses 1741 2090 +349 + Partials 479 472 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
anik120force-pushed
the
config-api-controller-integration
branch
from
February 3, 2026 18:31
1d4703f to
278d27fCompare**Summary** Completes Phase 3 of the [Deployment Configuration RFC](https://docs.google.com/document/d/1bDo3W1asZqjJTgZy7BcVOGtKOEukp0vUi5CO1ac3vwc/edit?usp=sharing). Extracts `deploymentConfig` from validated ClusterExtension configuration and passes it to the bundle renderer. Builds on: - (PR2454)[operator-framework#2454]: Config API and JSON schema validation - (PR2469)[operator-framework#2469]: Renderer support for applying deployment customizations This completes the RFC - users can now customize operator deployments via ClusterExtension.spec.config.inline: ``` config: configType: Inline inline: watchNamespace: "some-namespace" deploymentConfig: env: - name: TEST_ENV value: test-value nodeSelector: kubernetes.io/os: linux ```
anik120force-pushed
the
config-api-controller-integration
branch
from
February 3, 2026 18:45
278d27f to
d7cb702CompareContributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tmshort
reviewed
Feb 3, 2026
| if err != nil { | ||
| return nil, errorutil.NewTerminalError(ocv1.ReasonInvalidConfiguration, fmt.Errorf("invalid deploymentConfig: %w", err)) | ||
| } | ||
| opts = append(opts, render.WithDeploymentConfig(deploymentConfig)) |
Contributor
There was a problem hiding this comment.
What happens when deploymentConfig is nil (i.e. first return case. of return nil, nil?
tmshort
reviewed
Feb 3, 2026
| ResourceGenerators: []render.ResourceGenerator{ | ||
| func(rv1 *bundle.RegistryV1, opts render.Options) ([]client.Object, error) { | ||
| t.Log("ensure deploymentConfig is nil for empty config object") | ||
| require.Nil(t, opts.DeploymentConfig) |
Contributor
There was a problem hiding this comment.
Although, you do seem to test it here.
tmshort
commented
Feb 3, 2026
Contributor
/lgtm |
perdasilva
commented
Feb 3, 2026
Contributor
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Uh oh!
There was an error while loading. Please reload this page.
anik120 added a commit
to anik120/operator-controller
that referenced
this pull request
Mar 2, 2026
Adds user-facing documentation for the Bundle Deployment Configuration feature, which provides feature parity with OLM v0's `Subscription.spec.config` (SubscriptionConfig). **What's included:** - How to enable the `DeploymentConfig` feature gate - Complete configuration reference for all deployment customization options: - Environment variables (`env`, `envFrom`) - Resource requirements (`resources`) - Node placement (`nodeSelector`, `tolerations`, `affinity`) - Storage (`volumes`, `volumeMounts`) - Annotations - Migration guide from OLM v0's SubscriptionConfig to OLM v1 - Validation details including how the JSON schema is generated for registry+v1 bundles - Troubleshooting and verification steps **Related work:** - RFC: [Deployment Configuration (achieving feature parity with OLMv0's SubscriptionConfig)](https://docs.google.com/document/d/18O4qBvu5I4WIJgo5KU1opyUKcrfgk64xsI3tyXxmVEU/edit?usp=sharing) - Implementation: - operator-framework#2454 (schema generation and validation) - operator-framework#2469 (renderer support) - operator-framework#2482 (controller integration) - operator-framework#2527 (DeploymentConfig feature gate) This documentation is placed in `docs/draft/howto/` as the feature is currently `experimental` and requires the `DeploymentConfig` feature gate to be enabled.
4 tasks
openshift-merge-botBot
pushed a commit
that referenced
this pull request
Mar 2, 2026
Adds user-facing documentation for the Bundle Deployment Configuration feature, which provides feature parity with OLM v0's `Subscription.spec.config` (SubscriptionConfig). **What's included:** - How to enable the `DeploymentConfig` feature gate - Complete configuration reference for all deployment customization options: - Environment variables (`env`, `envFrom`) - Resource requirements (`resources`) - Node placement (`nodeSelector`, `tolerations`, `affinity`) - Storage (`volumes`, `volumeMounts`) - Annotations - Migration guide from OLM v0's SubscriptionConfig to OLM v1 - Validation details including how the JSON schema is generated for registry+v1 bundles - Troubleshooting and verification steps **Related work:** - RFC: [Deployment Configuration (achieving feature parity with OLMv0's SubscriptionConfig)](https://docs.google.com/document/d/18O4qBvu5I4WIJgo5KU1opyUKcrfgk64xsI3tyXxmVEU/edit?usp=sharing) - Implementation: - #2454 (schema generation and validation) - #2469 (renderer support) - #2482 (controller integration) - #2527 (DeploymentConfig feature gate) This documentation is placed in `docs/draft/howto/` as the feature is currently `experimental` and requires the `DeploymentConfig` feature gate to be enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes Phase 3 of the Deployment Configuration RFC. Extracts
deploymentConfigfrom validated ClusterExtension configuration and passes it to the bundle renderer.Builds on:
This completes the RFC - users can now customize operator deployments via
ClusterExtension.spec.config.inline:Description
Reviewer Checklist