Skip to content

🌱 MON-4516: Use endpointslices for metrics - #2516

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:mon-4516
Feb 19, 2026
Merged

🌱 MON-4516: Use endpointslices for metrics#2516
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:mon-4516

Conversation

@tmshort

@tmshorttmshort commented Feb 18, 2026

Copy link
Copy Markdown
Contributor
  • Add permissions on endpointslice to Prometheus Role
  • Use serviceDiscoveryRole: EndpointSlice in ServiceMonitors

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort
MON-4516: Use endpointslices for metrics
ff299d7
* Add permissions on endpointslice to Prometheus Role
* Use serviceDiscoveryRole: EndpointSlice in ServiceMonitors
Signed-off-by: Todd Short <tshort@redhat.com>
CopilotAI review requested due to automatic review settings February 18, 2026 19:08
@netlify

netlifyBot commented Feb 18, 2026•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commitff299d7
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/69960e21ad73d80008ade8ee
😎 Deploy Previewhttps://deploy-preview-2516--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tmshorttmshort mentioned this pull request Feb 18, 2026
Closed
CopilotAI reviewed Feb 18, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR configures the OpenShift monitoring ServiceMonitor to use EndpointSlices for service discovery instead of the older Endpoints API. This aligns with Kubernetes' recommended approach for service discovery, as EndpointSlices provide better scalability and performance for large clusters.

Changes:

  • Added serviceDiscoveryRole: EndpointSlice to the olmv1 ServiceMonitor resource
  • Added RBAC permissions for discovery.k8s.io/endpointslices to the metrics monitor role

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

FileDescription
helm/olmv1/templates/servicemonitor-olmv1-system-metrics-monitor.ymlAdded serviceDiscoveryRole field to enable EndpointSlice-based service discovery
helm/olmv1/templates/rbac/role-olmv1-system-metrics-monitor-role.ymlAdded required RBAC permissions for accessing endpointslices resources

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadhelm/olmv1/templates/servicemonitor-olmv1-system-metrics-monitor.yml
@codecov

codecovBot commented Feb 18, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.45%. Comparing base (130c987) to head (ff299d7).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2516 +/- ##
==========================================
- Coverage 73.21% 69.45% -3.77% 
==========================================
Files 102 102 Lines 8505 8505 ==========================================
- Hits 6227 5907 -320 - Misses 1802 2129 +327 + Partials 476 469 -7
FlagCoverage Δ
e2e45.91% <ø> (ø)
experimental-e2e12.72% <ø> (-40.67%)⬇️
unit57.89% <ø> (+0.02%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

oceanc80
oceanc80 reviewed Feb 19, 2026
View reviewed changes

@oceanc80oceanc80 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2026
rashmigottipati
rashmigottipati approved these changes Feb 19, 2026
View reviewed changes

@rashmigottipatirashmigottipati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2026
@openshift-ci

openshift-ciBot commented Feb 19, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oceanc80, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ciBot commented Feb 19, 2026

Copy link
Copy Markdown

@tmshort: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • codecov/projec

Only the following failed contexts/checkruns were expected:

  • Autovalidate
  • CodeQL analysis
  • Verify PR title
  • codecov/project
  • crd-diff
  • e2e
  • experimental-e2e
  • extension-developer-e2e
  • go-apidiff
  • go-verdiff
  • goreleaser
  • lint
  • netlify/olmv1/deploy-preview
  • st2ex-e2e
  • tide
  • unit-test-basic
  • upgrade-st2st-e2e
  • verify

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override codecov/projec

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tmshort

tmshort commented Feb 19, 2026

Copy link
Copy Markdown
ContributorAuthor

/override codecov/project

@openshift-ci

openshift-ciBot commented Feb 19, 2026

Copy link
Copy Markdown

@tmshort: Overrode contexts on behalf of tmshort: codecov/project

Details

In response to this:

/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot
openshift-merge-botBot merged commit 1ef820f into operator-framework:mainFeb 19, 2026
34 of 35 checks passed
@tmshort
tmshort deleted the mon-4516 branch February 19, 2026 18:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oceanc80oceanc80oceanc80 left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@rashmigottipatirashmigottipatirashmigottipati approved these changes
@perdasilvaperdasilvaAwaiting requested review from perdasilva

Assignees

@rashmigottipatirashmigottipati

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tmshort@rashmigottipati@oceanc80