Uh oh!
There was an error while loading. Please reload this page.
🌱 Update registry+v1 revision phases - #2520
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Updates the operator-controller “revision phases” model to a more granular set of phases and refreshes phase sorting expectations accordingly.
Changes:
- Replaces RBAC/RBACBindings with Identity/Roles/Bindings and adds new phases (Configuration/Infrastructure/Scaling/Admission).
- Updates the GroupKind→Phase mapping to reflect the new phase taxonomy and ordering.
- Adjusts unit tests for phase sorting and revision generation to match the new phase outputs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| internal/operator-controller/applier/phase.go | Introduces new phases and updates default ordering + GroupKind phase mappings. |
| internal/operator-controller/applier/phase_test.go | Updates phase sort test cases and expectations for the new phase breakdown. |
| internal/operator-controller/applier/boxcutter_test.go | Updates revision generator tests to expect objects split across the new phases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
e7b39fb to
110babeCompareCodecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #2520 +/- ##
==========================================
- Coverage 73.27% 72.03% -1.24%
==========================================
Files 103 103 Lines 8516 8686 +170 ==========================================
+ Hits 6240 6257 +17 - Misses 1801 1946 +145 - Partials 475 483 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
110babe to
fe7852dCompareThere was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fe7852d to
b6db8c1Compare
…rdering Restructure the phase definitions to provide more granular control over the order in which Kubernetes resources are applied during extension installation. The previous coarse-grained phases (rbac, deploy, publish) are replaced with finer-grained phases that better reflect resource dependency chains and operational best practices. Phase changes: - Split "rbac" into "identity" (ServiceAccount), "roles" (ClusterRole, Role), and "bindings" (ClusterRoleBinding, RoleBinding) for explicit ordering of RBAC prerequisites before their bindings - Extract "configuration" phase (Secret, ConfigMap) from "deploy" so config resources are available before workloads that mount them - Extract "infrastructure" phase (Service, Issuer) from "deploy" so services and cert-manager issuers exist before workloads reference them - Add "scaling" phase (VerticalPodAutoscaler) after deploy for autoscaling policies to target running workloads - Add "admission" phase (ValidatingWebhookConfiguration, MutatingWebhookConfiguration) as the final phase so webhooks are registered only after their backing services are ready - Move CRDs before roles/bindings so RBAC rules referencing custom resources can be validated - Add cert-manager Certificate to "deploy" phase alongside Deployment - Add monitoring resources (PrometheusRule, ServiceMonitor, PodMonitor) and OpenShift console resources to "publish" phase - Remove explicit mappings for workload kinds that already default to "deploy" (DaemonSet, StatefulSet, ReplicaSet, Pod, Job, CronJob) New phase order: namespaces → policies → identity → configuration → storage → crds → roles → bindings → infrastructure → deploy → scaling → publish → admission Signed-off-by: Per G. da Silva <pegoncal@redhat.com>
b6db8c1 to
0ee177bCompareThere was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
tmshort
commented
Feb 24, 2026
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
662ecf2
into
operator-framework:mainUh oh!
There was an error while loading. Please reload this page.
Description
Restructures the registry+v1 revision phase definitions to provide more granular control over the order in which Kubernetes resources are applied during extension installation. The phase definition is described in the this RFC.
The previous coarse-grained phases (
rbac,deploy,publish) are replaced with finer-grained phases that better reflect resource dependency chains and operational best practices.Note:
OLMv1 currently only supports registry+v1 content. The registry+v1 format only supports a limited
set of object kinds defined here.
The phase mapping considers all allowable registry+v1 bundle format resource with the following changes:
This PR has resulted in the removal of some kinds that were previously defined (e.g. HorizontalPodAutoscaler, ResourceQuota, and LimitRange) that are not expected to be present in registry+v1 bundles. Adding new kinds to existing, or new, phases later on should not constitute a breaking change since existing revisions would not have their phase composition changed
Phase changes
rbacidentityrbacrolesrbac-bindingsbindingsdeploy(partial)configurationdeploy(partial)infrastructurescalingpublish(partial)admissionNew phase order
Key design decisions
identity), then role definitions (roles), then bindings (bindings), ensuring prerequisites exist before being referencedconfigurationbeforedeploy, so Pods can mount them immediatelyinfrastructurebeforedeploy, so workloads can reference themroles/bindingsso RBAC rules referencing custom resources can be validatedpublishphasedeployphaseReviewer Checklist