Uh oh!
There was an error while loading. Please reload this page.
🌱 Rename rev to cer in ClusterExtensionRevision reconciler for consistency - #2522
Conversation
Standardize the parameter name from `rev` to `cer` across reconcile, establishWatch, listPreviousRevisions, and toBoxcutterRevision methods to match the naming convention used elsewhere in the controller. Also simplify the establishWatch signature to a single line. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR standardizes the parameter naming in the ClusterExtensionRevision reconciler by renaming rev to cer across multiple methods. This aligns with the naming convention already established in other methods of the same reconciler (e.g., delete, archive, and all status helper functions).
Changes:
- Renamed parameter from
revtocerin four reconciler methods for consistency - Renamed
boxcutterRevtorevisioninestablishWatchmethod - Simplified the
establishWatchmethod signature to a single line
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #2522 +/- ##
==========================================
+ Coverage 70.11% 72.08% +1.96%
==========================================
Files 103 103 Lines 8686 8686 ==========================================
+ Hits 6090 6261 +171 + Misses 2145 1944 -201 - Partials 451 481 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pedjak The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4121321
into
operator-framework:mainUh oh!
There was an error while loading. Please reload this page.
Description
Standardize the parameter name from
revtoceracross reconcile, establishWatch, listPreviousRevisions, and toBoxcutterRevision methods to match the naming convention used elsewhere in the controller. Also simplify the establishWatch signature to a single line.Reviewer Checklist