Skip to content

🐛 Add delete ClusterExtensionRevision perm - #2545

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
perdasilva:fixup-cer-perms
Mar 9, 2026
Merged

🐛 Add delete ClusterExtensionRevision perm#2545
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
perdasilva:fixup-cer-perms

Conversation

@perdasilva

Copy link
Copy Markdown
Contributor

Description

Adds missing delete ClusterExtensionRevision permission to operator-controller service account. This is required because the controller also manages the number of archived revisions by deleting older revisions to keep maintain a maximum number of archived revisions on the cluster.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

CopilotAI review requested due to automatic review settings March 9, 2026 13:49
@netlify

netlifyBot commented Mar 9, 2026

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit6f92299
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/69af1570ac9e770008a7bd00
😎 Deploy Previewhttps://deploy-preview-2545--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the missing delete RBAC verb for clusterextensionrevisions to the operator-controller’s ClusterRole so it can prune archived revisions.

Changes:

  • Added delete permission for clusterextensionrevisions in the experimental manifest.
  • Added the same permission in the experimental E2E manifest.
  • Added the same permission in the Helm chart ClusterRole template.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

FileDescription
manifests/experimental.yamlGrants delete on clusterextensionrevisions for deployed experimental installs.
manifests/experimental-e2e.yamlGrants delete on clusterextensionrevisions for E2E test installs.
helm/olmv1/templates/rbac/clusterrole-operator-controller-manager-role.ymlKeeps Helm-deployed RBAC in sync by including the delete verb.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tmshort

Copy link
Copy Markdown
Contributor

I'm also having failures pulling down v0.4.3 and latest from gcr.io

@tmshort

Copy link
Copy Markdown
Contributor

/approve

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2026

@rashmigottipatirashmigottipati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2026
@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rashmigottipati, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Per G. da Silva <pegoncal@redhat.com>
@openshift-ciopenshift-ciBot removed the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2026
@tmshort

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2026
@codecov

codecovBot commented Mar 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.60%. Comparing base (e0fce0e) to head (6f92299).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2545 +/- ##
==========================================
+ Coverage 68.58% 68.60% +0.02% 
==========================================
Files 131 131 Lines 9330 9330 ==========================================
+ Hits 6399 6401 +2 + Misses 2439 2438 -1 + Partials 492 491 -1 
FlagCoverage Δ
e2e42.22% <ø> (-0.25%)⬇️
experimental-e2e51.60% <ø> (+0.02%)⬆️
unit53.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort

Copy link
Copy Markdown
Contributor

/override codecov/project

Not sure why it's still running...

@openshift-ci

Copy link
Copy Markdown

@tmshort: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • codecov/project

Only the following failed contexts/checkruns were expected:

  • Verify PR title
  • crd-diff
  • e2e
  • experimental-e2e
  • extension-developer-e2e
  • go-apidiff
  • go-verdiff
  • goreleaser
  • lint
  • netlify/olmv1/deploy-preview
  • st2ex-e2e
  • tide
  • unit-test-basic
  • upgrade-st2st-e2e
  • verify

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override codecov/project

Not sure why it's still running...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tmshorttmshort closed this Mar 9, 2026
@tmshorttmshort reopened this Mar 9, 2026
@tmshort

Copy link
Copy Markdown
Contributor

/override codecov/project

@openshift-ci

Copy link
Copy Markdown

@tmshort: Overrode contexts on behalf of tmshort: codecov/project

Details

In response to this:

/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot
openshift-merge-botBot merged commit 6f23a79 into operator-framework:mainMar 9, 2026
43 of 44 checks passed
dtfranz pushed a commit to dtfranz/operator-controller that referenced this pull request Mar 10, 2026
Signed-off-by: Per G. da Silva <pegoncal@redhat.com>
Co-authored-by: Per G. da Silva <pegoncal@redhat.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@perdasilva@tmshort@rashmigottipati