Skip to content

🌱 Boxcutter Library Update - #2554

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
dtfranz:boxcutter-update
Mar 12, 2026
Merged

🌱 Boxcutter Library Update#2554
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
dtfranz:boxcutter-update

Conversation

@dtfranz

@dtfranzdtfranz commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

Description

Updates boxcutter library to (breaking) version v0.11.0.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

CopilotAI review requested due to automatic review settings March 11, 2026 08:38
@openshift-ciopenshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the experimental Boxcutter-based reconciliation path to align with a newer Boxcutter library release and accompanying dependency bumps.

Changes:

  • Bump pkg.package-operator.run/boxcutter to v0.11.0 and adjust the ClusterExtensionRevision controller to use the updated revision/phase building APIs.
  • Update several Kubernetes module versions in go.mod/go.sum.
  • Add a top-level @WIP tag to the BoxcutterRuntime e2e feature.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
FileDescription
test/e2e/features/revision.featureAdds an @WIP tag to the ClusterExtensionRevision e2e feature file.
internal/operator-controller/controllers/revision_engine_factory.goUpdates Boxcutter engine construction to match new comparator/object-engine wiring.
internal/operator-controller/controllers/clusterextensionrevision_controller.goRefactors revision construction to use NewRevisionWithOwner and phases-based helpers.
go.modBumps Boxcutter and several k8s.io/* module versions.
go.sumUpdates module checksums for the Boxcutter bump.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadgo.mod
Comment threadtest/e2e/features/revision.feature Outdated
@netlify

netlifyBot commented Mar 11, 2026

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commite1a07cf
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/69b20cff46c6c80008ede526
😎 Deploy Previewhttps://deploy-preview-2554--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

CopilotAI review requested due to automatic review settings March 11, 2026 09:49
@dtfranz
dtfranz marked this pull request as ready for review March 11, 2026 09:50
@openshift-ciopenshift-ciBot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

internal/operator-controller/controllers/clusterextensionrevision_controller.go:149

  • The error message here still says "converting to boxcutter revision", but the helper was renamed to buildBoxcutterPhases and now returns phases/options (not a revision). Updating the message will make failures easier to understand and debug (e.g., "building boxcutter phases").
	phases, opts, err := c.buildBoxcutterPhases(ctx, cer)
if err != nil {
setRetryingConditions(cer, err.Error())
return ctrl.Result{}, fmt.Errorf("converting to boxcutter revision: %v", err)
}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecovBot commented Mar 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 64.30%. Comparing base (6f23a79) to head (e1a07cf).
⚠️ Report is 6 commits behind head on main.

Files with missing linesPatch %Lines
...-controller/controllers/revision_engine_factory.go0.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #2554 +/- ##
==========================================
- Coverage 68.60% 64.30% -4.30% 
==========================================
Files 131 131 Lines 9330 9333 +3 ==========================================
- Hits 6401 6002 -399 - Misses 2438 2854 +416 + Partials 491 477 -14 
FlagCoverage Δ
e2e42.21% <0.00%> (-0.05%)⬇️
experimental-e2e11.82% <0.00%> (-39.76%)⬇️
unit53.84% <95.45%> (+0.02%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thetechnick

Copy link
Copy Markdown
Contributor

Looks good from my end :)

CopilotAI review requested due to automatic review settings March 12, 2026 00:15

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

internal/operator-controller/controllers/clusterextensionrevision_controller.go:149

  • The error returned from buildBoxcutterPhases is being re-wrapped with %v and an outdated message ("converting to boxcutter revision"). Consider updating the message to reflect that this step builds phases/options, and use %w so callers can unwrap the original error for classification/logging.
	phases, opts, err := c.buildBoxcutterPhases(ctx, cer)
if err != nil {
setRetryingConditions(cer, err.Error())
return ctrl.Result{}, fmt.Errorf("converting to boxcutter revision: %v", err)
}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadgo.mod
Updates boxcutter library to v0.11.0 and adjusts code to accept the breaking changes.
Signed-off-by: Daniel Franz <dfranz@redhat.com>
@dtfranz

Copy link
Copy Markdown
ContributorAuthor

Whoops, sorry for erasing then re-applying your changes @perdasilva 😵 I had a combo of the github page not showing your changes and my local branch having a diff from upstream so I just assumed I had forgotten to push something. The branch should be identical now to your push, though.

@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 12, 2026
@camilamacedo86

Copy link
Copy Markdown
Contributor

Lets wait an LGTM from @perdasilva then we override the codecov/project to get this one merged

@perdasilva

Copy link
Copy Markdown
Contributor

/override codecov/project

@openshift-ci

Copy link
Copy Markdown

@perdasilva: Overrode contexts on behalf of perdasilva: codecov/project

Details

In response to this:

/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot
openshift-merge-botBot merged commit f19c8c9 into operator-framework:mainMar 12, 2026
26 of 27 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@dtfranz@thetechnick@camilamacedo86@perdasilva