Skip to content

🌱 catalogd: fix cmdline typo - #2564

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
fgiudici:catalogd-cmd-typo
Mar 13, 2026
Merged

🌱 catalogd: fix cmdline typo#2564
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
fgiudici:catalogd-cmd-typo

Conversation

@fgiudici

@fgiudicifgiudici commented Mar 13, 2026

Copy link
Copy Markdown
Member

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@fgiudici
catalogd: fix cmdline typo
b5bfe34
Signed-off-by: Francesco Giudici <fgiudici@redhat.com>
CopilotAI review requested due to automatic review settings March 13, 2026 18:01
@netlify

netlifyBot commented Mar 13, 2026•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commitb5bfe34
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/69b4511765af7e000802ce27
😎 Deploy Previewhttps://deploy-preview-2564--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

rashmigottipati
rashmigottipati approved these changes Mar 13, 2026
View reviewed changes

@rashmigottipatirashmigottipati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉
/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2026
CopilotAI reviewed Mar 13, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a typo in the catalogd command-line flag help text.

Changes:

  • Corrected misspellings in the --pull-cas-dir flag description to improve CLI help output.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadcmd/catalogd/main.go
flags.StringVar(&cfg.keyFile, "tls-key", "", "Key file for TLS")
flags.IntVar(&cfg.webhookPort, "webhook-server-port", 9443, "Webhook server port")
flag.StringVar(&cfg.pullCasDir, "pull-cas-dir", "", "The directory of TLS certificate authoritiess to use for verifying HTTPS copullCasDirnnections to image registries.")
flags.StringVar(&cfg.pullCasDir, "pull-cas-dir", "", "The directory of TLS certificate authorities to use for verifying HTTPS connections to image registries.")

@fgiudicifgiudiciMar 13, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Guess if there are such tests, testing would fail.
Local testing was fine, if the test in the CI pipeline also pass my guess is that we don't have golden tests for --help output.

@codecov

codecovBot commented Mar 13, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.72%. Comparing base (18b2d2d) to head (b5bfe34).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2564 +/- ##
==========================================
+ Coverage 68.65% 68.72% +0.06% 
==========================================
Files 131 131 Lines 9333 9333 ==========================================
+ Hits 6408 6414 +6 + Misses 2436 2429 -7 - Partials 489 490 +1
FlagCoverage Δ
e2e42.45% <100.00%> (+0.24%)⬆️
experimental-e2e51.87% <100.00%> (+0.19%)⬆️
unit53.84% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort

tmshort commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ciBot commented Mar 13, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rashmigottipati, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2026
@openshift-merge-bot
openshift-merge-botBot merged commit 147cfa8 into operator-framework:mainMar 13, 2026
30 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@rashmigottipatirashmigottipatirashmigottipati approved these changes
@dtfranzdtfranzAwaiting requested review from dtfranz
@joelanfordjoelanfordAwaiting requested review from joelanford

Assignees

@rashmigottipatirashmigottipati

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fgiudici@tmshort@rashmigottipati