Skip to content

🌱 OPRUN-4512: Add override labeling for go-apidiff - #2565

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:override-go-apidiff
Mar 16, 2026
Merged

🌱 OPRUN-4512: Add override labeling for go-apidiff#2565
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:override-go-apidiff

Conversation

@tmshort

Copy link
Copy Markdown
Contributor

We can't get #2538 to merge without disabling go-apidiff

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Todd Short <tshort@redhat.com>
CopilotAI review requested due to automatic review settings March 13, 2026 19:50
@netlify

netlifyBot commented Mar 13, 2026

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit37aad80
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/69b46aa368cc810008fa5533
😎 Deploy Previewhttps://deploy-preview-2565--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an override mechanism to the go-apidiff GitHub Actions workflow, allowing PRs with the go-apidiff-override label to bypass API diff failures. This unblocks PR #2538 which introduces new/changed APIs that trigger apidiff failures.

Changes:

  • Makes the go-apidiff step non-blocking via continue-on-error: true and adds a follow-up step that fails the job only if apidiff failed and the PR lacks the go-apidiff-override label.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@openshift-ciopenshift-ciBot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 15, 2026

@rashmigottipatirashmigottipati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov

codecovBot commented Mar 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.69%. Comparing base (ac1fdfd) to head (37aad80).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2565 +/- ##
==========================================
+ Coverage 64.25% 68.69% +4.43% 
==========================================
Files 131 131 Lines 9288 9333 +45 ==========================================
+ Hits 5968 6411 +443 + Misses 2849 2431 -418 - Partials 471 491 +20 
FlagCoverage Δ
e2e42.23% <ø> (-0.14%)⬇️
experimental-e2e51.83% <ø> (+40.04%)⬆️
unit53.84% <ø> (+0.12%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@perdasilva

Copy link
Copy Markdown
Contributor

/approve
/lgtm

@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, perdasilva, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@droslean

Copy link
Copy Markdown

/refresh

@liangxia

Copy link
Copy Markdown

/cc @liangxia

@openshift-ci

Copy link
Copy Markdown

@liangxia: GitHub didn't allow me to request PR reviews from the following users: liangxia.

Note that only operator-framework members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @liangxia

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tmshorttmshort closed this Mar 16, 2026
@tmshorttmshort reopened this Mar 16, 2026
@tmshorttmshort changed the title 🌱 Add override labeling for go-apidiff🌱 OPRUN-4512: Add override labeling for go-apidiffMar 16, 2026
@tmshort

Copy link
Copy Markdown
ContributorAuthor

/approve cancel

@tmshort

Copy link
Copy Markdown
ContributorAuthor

/unapprove

@droslean

Copy link
Copy Markdown

/refresh

1 similar comment
@tmshort

Copy link
Copy Markdown
ContributorAuthor

/refresh

@openshift-merge-bot
openshift-merge-botBot merged commit ecec490 into operator-framework:mainMar 16, 2026
86 of 89 checks passed
@tmshort
tmshort deleted the override-go-apidiff branch March 19, 2026 15:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@tmshort@perdasilva@droslean@liangxia@rashmigottipati@camilamacedo86