Uh oh!
There was an error while loading. Please reload this page.
🌱 OPRUN-4644: Update curves for golang 1.26 - #2754
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the tlsprofiles utility’s custom curve name→tls.CurveID mapping to recognize new Go 1.26 post-quantum hybrid curves, and adds an additional alias for P-256 using its IANA/OpenSSL name.
Changes:
- Add Go 1.26 hybrid curve IDs
SecP256r1MLKEM768andSecP384r1MLKEM1024to local constants and the custom curve lookup map. - Add
"secp256r1"as an alias for"prime256v1"(both resolving totls.CurveP256). - Extend tests to cover the new curves and the
secp256r1alias behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/shared/util/tlsprofiles/tlsprofiles.go | Extends the custom curve ID mapping with Go 1.26 hybrid curves and adds secp256r1 aliasing to P-256. |
| internal/shared/util/tlsprofiles/tlsprofiles_test.go | Adds/updates unit tests validating the new curve names and the secp256r1→P-256 alias behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| {"secp256r1", true}, // IANA alias for prime256v1 | ||
| {"secp384r1", true}, | ||
| {"secp521r1", true}, | ||
| {"unknown-cuve", false}, |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #2754 +/- ##
==========================================
+ Coverage 66.95% 66.96% +0.01%
==========================================
Files 149 149 Lines 11341 11341 ==========================================
+ Hits 7593 7595 +2 + Misses 3191 3190 -1 + Partials 557 556 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
… alias Add the two NIST-curve ML-KEM post-quantum hybrids introduced in Go 1.26 to the custom curve map and local constants. Also add "secp256r1" as an alias for "prime256v1" using the IANA name for P-256. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Todd Short <tshort@redhat.com>
dtfranz
commented
Jun 10, 2026
/lgtm |
perdasilva
commented
Jun 10, 2026
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva, rashmigottipati The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f96144f
into
operator-framework:mainUh oh!
There was an error while loading. Please reload this page.
tlsprofiles: add SecP256r1MLKEM768, SecP384r1MLKEM1024, and secp256r1 alias
Add the two NIST-curve ML-KEM post-quantum hybrids introduced in Go 1.26 to the custom curve map and local constants. Also add "secp256r1" as an alias for "prime256v1" using the IANA name for P-256.
Description
Reviewer Checklist