Skip to content

🐛 Fix support-bundle collection on e2e failure - #2755

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
pedjak:worktree-fix-support-bundle
Jun 9, 2026
Merged

🐛 Fix support-bundle collection on e2e failure#2755
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
pedjak:worktree-fix-support-bundle

Conversation

@pedjak

@pedjakpedjak commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add test/e2e/support-bundle.yaml spec file with collectors for cluster diagnostics
  • Pass the spec file to the support-bundle CLI in the e2e workflow

Fixes the Error: no collectors specified to run error introduced in #2750.

Test plan

  • Verify e2e workflow collects support-bundle artifacts on failure

CopilotAI review requested due to automatic review settings June 9, 2026 12:50
@openshift-ci
openshift-ciBot requested review from dtfranz and grokspawnJune 9, 2026 12:50
CopilotAI reviewed Jun 9, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix support-bundle collection during e2e workflow failures by introducing an explicit SupportBundle spec file and passing it to the support-bundle CLI, addressing the “no collectors specified to run” error introduced in #2750.

Changes:

  • Add test/e2e/support-bundle.yaml to explicitly define support-bundle collectors.
  • Update the e2e GitHub Actions workflow to pass the spec file to support-bundle during failure diagnostics.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

FileDescription
test/e2e/support-bundle.yamlIntroduces a SupportBundle spec intended to define which diagnostics collectors run in CI.
.github/workflows/e2e.yamlUpdates the failure-handling step to invoke support-bundle with the new spec file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadtest/e2e/support-bundle.yaml Outdated
@netlify

netlifyBot commented Jun 9, 2026•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit7038fdc
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/6a28491243ceba0009848071
😎 Deploy Previewhttps://deploy-preview-2755--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changesRun an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

rashmigottipati
rashmigottipati approved these changes Jun 9, 2026
View reviewed changes

@rashmigottipatirashmigottipati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2026
@codecov

codecovBot commented Jun 9, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.95%. Comparing base (b15d736) to head (7038fdc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2755 +/- ##
==========================================
- Coverage 66.96% 66.95% -0.02% 
==========================================
Files 149 149 Lines 11341 11341 ==========================================
- Hits 7595 7593 -2 - Misses 3190 3191 +1 - Partials 556 557 +1
FlagCoverage Δ
e2e35.20% <ø> (+0.02%)⬆️
experimental-e2e52.55% <ø> (-0.05%)⬇️
unit52.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort

tmshort commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

/approve

@openshift-ciopenshift-ciBot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Jun 9, 2026
@pedjak
pedjakforce-pushed the worktree-fix-support-bundle branch from 71d4342 to e717fa6CompareJune 9, 2026 16:20
rashmigottipati
rashmigottipati approved these changes Jun 9, 2026
View reviewed changes

@rashmigottipatirashmigottipati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2026
@pedjak@claude
🐛 Fix support-bundle collection on e2e failure
7038fdc
Add test/e2e/support-bundle.yaml spec file with collectors for cluster
diagnostics and pass it to the support-bundle CLI in the e2e workflow.
Fixes the "no collectors specified to run" error introduced in operator-framework#2750.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
CopilotAI review requested due to automatic review settings June 9, 2026 17:10
@pedjak
pedjakforce-pushed the worktree-fix-support-bundle branch from e717fa6 to 7038fdcCompareJune 9, 2026 17:10
@openshift-ciopenshift-ciBot removed the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2026
CopilotAI reviewed Jun 9, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment threadtest/e2e/support-bundle.yaml
collectors:
- clusterResources: {}
- clusterInfo: {}
- logs: {}
rashmigottipati
rashmigottipati approved these changes Jun 9, 2026
View reviewed changes

@rashmigottipatirashmigottipati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2026
@openshift-ci

openshift-ciBot commented Jun 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rashmigottipati, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-botBot merged commit 53b5ecf into operator-framework:mainJun 9, 2026
21 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@rashmigottipatirashmigottipatirashmigottipati approved these changes
@dtfranzdtfranzAwaiting requested review from dtfranz
@grokspawngrokspawnAwaiting requested review from grokspawn

Assignees

@rashmigottipatirashmigottipati

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pedjak@tmshort@rashmigottipati