Skip to content

🌱 Apply cluster TLS profile to outgoing HTTP client - #2767

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:use-tls-profile-for-client
Jun 16, 2026
Merged

🌱 Apply cluster TLS profile to outgoing HTTP client#2767
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:use-tls-profile-for-client

Conversation

@tmshort

@tmshorttmshort commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Use the configured TLS profile (set via --tls-profile flags) for the catalogd HTTP client, consistent with how the metrics server TLS is configured. Falls back to TLS 1.2 minimum when no profile is set.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

CopilotAI review requested due to automatic review settings June 15, 2026 16:07
@netlify

netlifyBot commented Jun 15, 2026•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit2e77886
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/6a3053cb3d38e50008183d36
😎 Deploy Previewhttps://deploy-preview-2767--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changesRun an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci
openshift-ciBot requested review from oceanc80 and pedjakJune 15, 2026 16:08
CopilotAI reviewed Jun 15, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Applies the cluster’s configured TLS profile to the outgoing HTTP client so catalogd’s client behavior matches the TLS configuration approach used elsewhere (e.g., metrics server), while keeping a TLS 1.2 minimum as a fallback.

Changes:

  • Import TLS profile helper and apply it to the HTTP client TLS config when available.
  • Retain TLS 1.2 minimum as the default baseline.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadinternal/shared/util/http/httputil.go Outdated
Comment threadinternal/shared/util/http/httputil.go Outdated
@codecov

codecovBot commented Jun 15, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.76%. Comparing base (8807a64) to head (2e77886).
⚠️ Report is 2 commits behind head on main.

Files with missing linesPatch %Lines
internal/shared/util/http/httputil.go50.00%1 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #2767 +/- ##
==========================================
- Coverage 66.78% 66.76% -0.03% 
==========================================
Files 149 149 Lines 11382 11386 +4 ==========================================
Hits 7602 7602 - Misses 3221 3223 +2 - Partials 559 561 +2
FlagCoverage Δ
e2e35.14% <50.00%> (+0.04%)⬆️
experimental-e2e52.34% <50.00%> (+0.12%)⬆️
unit52.12% <50.00%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort
tmshortforce-pushed the use-tls-profile-for-client branch from df8aa6b to 79f5990CompareJune 15, 2026 19:04
@tmshort
tmshort requested a review from CopilotJune 15, 2026 19:18
CopilotAI reviewed Jun 15, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment threadinternal/shared/util/http/httputil.go Outdated
Comment threadinternal/shared/util/http/httputil.go Outdated
@tmshort
Apply cluster TLS profile to outgoing HTTP client
2e77886
Use the configured TLS profile (set via --tls-profile flags) for the
catalogd HTTP client, consistent with how the metrics server TLS is
configured. Falls back to TLS 1.2 minimum when no profile is set.
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
tmshortforce-pushed the use-tls-profile-for-client branch from 79f5990 to 2e77886CompareJune 15, 2026 19:34
@tmshort
tmshort requested a review from CopilotJune 15, 2026 19:37
CopilotAI reviewed Jun 15, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@perdasilva

perdasilva commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

/approve
/override codecov/patch

@openshift-ci

openshift-ciBot commented Jun 16, 2026

Copy link
Copy Markdown

@perdasilva: Overrode contexts on behalf of perdasilva: codecov/patch

Details

In response to this:

/approve
/override codecov/patch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2026
@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2026
@openshift-ci

openshift-ciBot commented Jun 16, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-botBot merged commit f600212 into operator-framework:mainJun 16, 2026
26 of 27 checks passed
@tmshort
tmshort deleted the use-tls-profile-for-client branch June 16, 2026 14:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@rashmigottipatirashmigottipatirashmigottipati approved these changes
@oceanc80oceanc80Awaiting requested review from oceanc80
@pedjakpedjakAwaiting requested review from pedjak

Assignees

@rashmigottipatirashmigottipati

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tmshort@perdasilva@rashmigottipati