Uh oh!
There was an error while loading. Please reload this page.
🌱 Remove asciinema upload from update-demos target - #2786
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR adjusts the update-demos Makefile target to generate demo recordings without uploading them to asciinema.org, avoiding CI failures caused by asciinema.org being unreachable from GitHub-hosted runners.
Changes:
- Remove the
-u(upload) flag from themake update-demosinvocation. - Update the target’s extended help text to no longer claim it uploads demos.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
asciinema.org is unreachable from GitHub Actions runners (Azure) since June 16, 2026 (asciinema/asciinema-server#479), causing the daily demo CI job to fail consistently. The upload step is not essential — the CI job's purpose is to validate that demo recordings can be generated successfully. Remove the -u flag and update the target's EXHELP text accordingly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
0e91e43 to
d505ae9CompareCodecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #2786 +/- ##
==========================================
- Coverage 70.44% 70.42% -0.02%
==========================================
Files 143 143 Lines 10617 10617 ==========================================
- Hits 7479 7477 -2 - Misses 2578 2579 +1 - Partials 560 561 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pedjak The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
00db91d
into
operator-framework:mainUh oh!
There was an error while loading. Please reload this page.
Summary
-u(upload) flag frommake update-demosso demo recordings are generated without uploading to asciinema.orgWhy
asciinema.org has been unreachable from GitHub Actions runners (hosted on Azure) since ~June 16, 2026, causing the daily
demoCI job to fail consistently. See asciinema/asciinema-server#479.The upload was never essential to the CI job — the purpose is to validate that demo recordings can be generated successfully. According to the issue, the public asciinema server was not meant for CI. "Host your own" was the given alternative.
Test plan
make update-demosruns successfully without the-uflagdemoCI job passes on this PR🤖 Generated with Claude Code