Skip to content

🐛 fix: missing olm.operatorNamespace annotation - #2803

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
Kajot-dev:fix/olm.operatorNamespace
Jul 6, 2026
Merged

🐛 fix: missing olm.operatorNamespace annotation#2803
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
Kajot-dev:fix/olm.operatorNamespace

Conversation

@Kajot-dev

@Kajot-devKajot-dev commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Description

OLMv0 sets the olm.* annotations from OperatorGroup on the spec.template.metadata.annotation section of the operator Deployment. To maintain interoperability OLM v1 does do the same for olm.targetNamespaces annotation - but does NOT do it for olm.operatorNamespace. There are opeators that rely on this (see linked issue)

Fixes: #2802

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

CopilotAI review requested due to automatic review settings July 2, 2026 16:35
@openshift-ci
openshift-ciBot requested review from dtfranz and grokspawnJuly 2, 2026 16:35
@netlify

netlifyBot commented Jul 2, 2026

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit1dd8c9c
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/6a47b46771ded70008769d7c
😎 Deploy Previewhttps://deploy-preview-2803--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changesRun an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restores OLMv0 interoperability by ensuring generated CSV-based Deployment pod templates include the olm.operatorNamespace annotation (alongside the existing olm.targetNamespaces) so operators relying on those annotations behave correctly under OLMv1.

Changes:

  • Set olm.operatorNamespace on generated Deployment.spec.template.metadata.annotations from render.Options.InstallNamespace.
  • Update unit tests to assert the new annotation is present in generated deployment templates.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

FileDescription
internal/operator-controller/rukpak/render/registryv1/generators/generators.goAdds olm.operatorNamespace to generated CSV deployment pod-template annotations (OLMv0 parity).
internal/operator-controller/rukpak/render/registryv1/generators/generators_test.goUpdates expected deployment-template annotations to include olm.operatorNamespace.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: jjaruszewski <jjaruszewski@man.poznan.pl>
@Kajot-dev
Kajot-devforce-pushed the fix/olm.operatorNamespace branch from 723c986 to 1dd8c9cCompareJuly 3, 2026 13:08
@Kajot-dev

Copy link
Copy Markdown
ContributorAuthor

Fixed the regression tests

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2026
@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2026
@openshift-merge-bot
openshift-merge-botBot merged commit 7461774 into operator-framework:mainJul 6, 2026
24 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

olm.operatorNamespace annotation is missing

3 participants

@Kajot-dev@perdasilva