Skip to content

Rename variable to avoid shadowing - #455

Merged
joelanford merged 1 commit into
operator-framework:mainfrom
m1kola:renames
Oct 12, 2023
Merged

Rename variable to avoid shadowing#455
joelanford merged 1 commit into
operator-framework:mainfrom
m1kola:renames

Conversation

@m1kola

@m1kolam1kola commented Oct 12, 2023

Copy link
Copy Markdown
Member

Description

Subj. Follow up for #453 (comment)

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola
m1kola requested a review from a team as a code ownerOctober 12, 2023 08:46
@m1kolam1kola mentioned this pull request Oct 12, 2023
4 tasks
@codecov

codecovBot commented Oct 12, 2023

Copy link
Copy Markdown

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c24fdbc) 66.07% compared to head (133ad4e) 83.80%.

Additional details and impacted files
@@ Coverage Diff @@## main #455 +/- ##
===========================================
+ Coverage 66.07% 83.80% +17.73% 
===========================================
Files 23 23 Lines 846 846 ===========================================
+ Hits 559 709 +150 + Misses 203 94 -109 + Partials 84 43 -41 
FlagCoverage Δ
e2e65.95% <0.00%> (-0.12%)⬇️
unit76.58% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

FilesCoverage Δ
internal/resolution/variables/bundle.go100.00% <100.00%> (+23.52%)⬆️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelanford
joelanford added this pull request to the merge queue Oct 12, 2023
Merged via the queue into operator-framework:main with commit f178f75Oct 12, 2023
@m1kola
m1kola deleted the renames branch October 12, 2023 14:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@m1kola@joelanford