Uh oh!
There was an error while loading. Please reload this page.
Add k8s.io/apimachinery/pkg/util/sets - #462
Merged
Merged
Conversation
Switches from `map` of empty structs to using sets package from apimachinery utils. Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
m1kola
marked this pull request as ready for review
October 16, 2023 10:25
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@## main #462 +/- ##
=======================================
Coverage 83.80% 83.80% =======================================
Files 23 23 Lines 846 846 =======================================
Hits 709 709 Misses 94 94 Partials 43 43
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
stevekuznetsov
added this pull request to the merge queue
Oct 16, 2023
LalatenduMohanty pushed a commit
to LalatenduMohanty/operator-controller
that referenced
this pull request
Dec 19, 2024
…ller-operator (operator-framework#462) Standardizing this method simplifies workflows and makes the project more contributor-friendly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switches from
mapof emptystructs to using sets package from apimachinery utils.Note: there is also
internal/resolution/variablesources/crd_constraints.gowhich uses map for empty structs, but there is #461 which modifies this file and makes use of sets package.Fixes#454
Reviewer Checklist