Uh oh!
There was an error while loading. Please reload this page.
🌱 Part 4: Reduce number of variable sources. Required packages - #500
Merged
m1kola merged 1 commit intoNov 10, 2023
Merged
Conversation
This was referenced Oct 31, 2023
m1kolaforce-pushed
the
shrink_variable_sources_p4
branch
from
October 31, 2023 16:46
1ba218a to
764afeeComparem1kolaforce-pushed
the
shrink_variable_sources_p4
branch
3 times, most recently
from
November 2, 2023 17:11
9e70605 to
fb7fc7dComparem1kolaforce-pushed
the
shrink_variable_sources_p4
branch
3 times, most recently
from
November 3, 2023 16:44
90de92a to
dfee29bComparem1kolaforce-pushed
the
shrink_variable_sources_p4
branch
from
November 7, 2023 15:11
dfee29b to
7fc644aCompareCodecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@## main #500 +/- ##
==========================================
+ Coverage 84.45% 85.21% +0.76%
==========================================
Files 23 23 Lines 907 893 -14 ==========================================
- Hits 766 761 -5 + Misses 96 91 -5 + Partials 45 41 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
m1kolaforce-pushed
the
shrink_variable_sources_p4
branch
2 times, most recently
from
November 7, 2023 17:03
1e883c2 to
1a29986Compare
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
m1kolaforce-pushed
the
shrink_variable_sources_p4
branch
from
November 7, 2023 17:05
1a29986 to
6585f6eComparem1kola
commented
Nov 7, 2023
| By("running reconcile") | ||
| res, err := reconciler.Reconcile(ctx, ctrl.Request{NamespacedName: opKey}) | ||
| Expect(res).To(Equal(ctrl.Result{})) | ||
| Expect(err).To(MatchError(fmt.Sprintf("no package '%s' found", pkgName))) |
MemberAuthor
There was a problem hiding this comment.
Since I had similar comments on previous parts of this refactoring & most of our errors use double quotation marks I updated the format here.
I'm happy to revert this and move into a separate PR if this is too distracting
m1kola
marked this pull request as ready for review
November 7, 2023 17:15
Comment on lines
+45
to
+53
| if versionRange != "" && channelName != "" { | ||
| return nil, fmt.Errorf("no package %q matching version %q found in channel %q", packageName, versionRange, channelName) | ||
| } | ||
| if versionRange != "" { | ||
| return nil, fmt.Errorf("no package %q matching version %q found", packageName, versionRange) | ||
| } | ||
| if channelName != "" { | ||
| return nil, fmt.Errorf("no package %q found in channel %q", packageName, channelName) | ||
| } |
Member
There was a problem hiding this comment.
What do you think about building up the error message as we're building the predicates (since we're already making the necessary conditional checks as we go)?
MemberAuthor
There was a problem hiding this comment.
I think I'm not in favour of this approach because:
- There are more combinations of errors than we have conditions for predicates. Unless I'm missing something, we will have to add more
ifs under existing predicateifs to get equivalent behaviour - Might be just me, but when I debug an error or read code I appreicate when codebase has unique errors and it is clear which condition yields the error. I found it quite hard to follow what was going on with errors in this PoC which had similar approach.
Contributor
There was a problem hiding this comment.
I agree with the emphasis on readability here.
awgreene
approved these changes
Nov 10, 2023
awgreene
added this pull request to the merge queue
Nov 10, 2023
m1kola
commented
Nov 10, 2023
MemberAuthor
For some reasons jobs in the merge queue did not get triggered. Probably will have to wait for it to timeout and requeue again. |
m1kola
removed this pull request from the merge queue due to a manual request
Nov 10, 2023
Uh oh!
There was an error while loading. Please reload this page.
m1kola
added this pull request to the merge queue
Nov 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Spliting #460 into smaller chunks. Related to #437
In this part I extract code related to creating required package variables from
RequiredPackageVariableSourceandOperatorVariableSourceinto a separate function.RequiredPackageVariableSourcegets removed in this PR.OperatorVariableSourcewill be removed later in #501Reviewer Checklist