Skip to content

✨ Respect upgrade constraint policy set on Operator - #520

Merged
m1kola merged 1 commit into
operator-framework:mainfrom
m1kola:add_upgradeConstraintPolicy
Nov 7, 2023
Merged

✨ Respect upgrade constraint policy set on Operator#520
m1kola merged 1 commit into
operator-framework:mainfrom
m1kola:add_upgradeConstraintPolicy

Conversation

@m1kola

@m1kolam1kola commented Nov 6, 2023

Copy link
Copy Markdown
Member

Description

Closes#449

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ciopenshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 6, 2023
@m1kolam1kola changed the title ✨ Add upgrade constraint policy✨ Respect upgrade constraint policy set on OperatorNov 6, 2023
@m1kola
m1kolaforce-pushed the add_upgradeConstraintPolicy branch 2 times, most recently from 5b9e713 to f1d4d8eCompareNovember 6, 2023 16:50
Comment threadinternal/resolution/variablesources/installed_package.go Outdated
Comment threadinternal/resolution/variablesources/installed_package.go
@openshift-merge-robotopenshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 6, 2023
@m1kola
m1kolaforce-pushed the add_upgradeConstraintPolicy branch from f1d4d8e to c7c44e6CompareNovember 7, 2023 10:10
@openshift-merge-robotopenshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2023
@codecov

codecovBot commented Nov 7, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (69db2ad) 84.41% compared to head (2dea4fc) 84.45%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #520 +/- ##
==========================================
+ Coverage 84.41% 84.45% +0.03% 
==========================================
Files 23 23 Lines 892 907 +15 ==========================================
+ Hits 753 766 +13 - Misses 95 96 +1 - Partials 44 45 +1 
FlagCoverage Δ
e2e65.93% <65.30%> (+0.01%)⬆️
unit79.43% <73.46%> (-0.11%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

FilesCoverage Δ
internal/controllers/variable_source.go72.72% <100.00%> (ø)
...al/resolution/variablesources/bundle_deployment.go100.00% <100.00%> (+21.05%)⬆️
...al/resolution/variablesources/installed_package.go71.42% <71.05%> (-2.49%)⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1kola
m1kolaforce-pushed the add_upgradeConstraintPolicy branch from c7c44e6 to 7c27170CompareNovember 7, 2023 11:12
This commit makes OLM respect `.spec.upgradeConstraintPolicy`
set on an `Operator` CR when chosing upgrade edges.
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola
m1kolaforce-pushed the add_upgradeConstraintPolicy branch from 7c27170 to 2dea4fcCompareNovember 7, 2023 11:54
@m1kola
m1kola marked this pull request as ready for review November 7, 2023 12:03
@m1kola
m1kola requested a review from a team as a code ownerNovember 7, 2023 12:03
@openshift-ciopenshift-ciBot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2023
@m1kola
m1kola added this pull request to the merge queue Nov 7, 2023
Merged via the queue into operator-framework:main with commit 8c59a33Nov 7, 2023
@m1kola
m1kola deleted the add_upgradeConstraintPolicy branch November 7, 2023 14:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Respect .spec.upgradeConstraintPolicy

3 participants

@m1kola@joelanford@openshift-merge-robot