Skip to content

🐛 Wait for catalog deletion before recreation - #537

Merged
awgreene merged 1 commit into
operator-framework:mainfrom
m1kola:gh536_object_is_being_deleted_flake
Nov 13, 2023
Merged

🐛 Wait for catalog deletion before recreation#537
awgreene merged 1 commit into
operator-framework:mainfrom
m1kola:gh536_object_is_being_deleted_flake

Conversation

@m1kola

@m1kolam1kola commented Nov 10, 2023

Copy link
Copy Markdown
Member

Description

Fixes#536

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Mikalai Radchuk
Wait for catalog deletion before recreation
3e886be
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@openshift-ciopenshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2023
@codecov

codecovBot commented Nov 10, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7e321b4) 85.30% compared to head (3e886be) 83.69%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #537 +/- ##
==========================================
- Coverage 85.30% 83.69% -1.61% 
==========================================
Files 23 20 -3 Lines 898 822 -76 ==========================================
- Hits 766 688 -78 - Misses 91 92 +1 - Partials 41 42 +1
FlagCoverage Δ
e2e63.86% <ø> (-2.17%)⬇️
unit78.59% <ø> (-1.46%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1kola
m1kola marked this pull request as ready for review November 10, 2023 17:33
@m1kola
m1kola requested a review from a team as a code ownerNovember 10, 2023 17:33
@openshift-ciopenshift-ciBot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2023
awgreene
awgreene reviewed Nov 13, 2023
View reviewed changes
Comment threadtest/e2e/install_test.go
awgreene
awgreene approved these changes Nov 13, 2023
View reviewed changes

@awgreeneawgreene left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepting @ncdc's suggestion. Looks good.

@awgreene
awgreene added this pull request to the merge queue Nov 13, 2023
Merged via the queue into operator-framework:main with commit 56683d9Nov 13, 2023
@m1kola
m1kola deleted the gh536_object_is_being_deleted_flake branch November 13, 2023 17:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncdcncdcncdc left review comments
@awgreeneawgreeneawgreene approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

E2E flake - object is being deleted: catalogs.catalogd.operatorframework.io "test-catalog" already exists

3 participants

@m1kola@ncdc@awgreene