Uh oh!
There was an error while loading. Please reload this page.
✨ Fix e2e - #843
Merged
Merged
Conversation
tmshort
commented
May 10, 2024
Contributor
Is this supposed to fix the e2e? It's still failing. |
varshaprasad96force-pushed
the
fix/e2e
branch
2 times, most recently
from
May 10, 2024 18:52
7f6d23f to
7e9be69CompareCodecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## helm-poc #843 +/- ##
===========================================
Coverage ? 64.90% ===========================================
Files ? 20 Lines ? 1607 Branches ? 0 ===========================================
Hits ? 1043 Misses ? 456 Partials ? 108
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tmshort
commented
May 10, 2024
Contributor
e2e is passing! |
varshaprasad96 added a commit
to varshaprasad96/operator-controller
that referenced
this pull request
May 10, 2024
Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
github-merge-queueBot
pushed a commit
that referenced
this pull request
May 30, 2024
…s into the cluster (#846) * Helm POC rebase-a-thon * Unpack Image (#811) Builds and loads the unpacker binary into the operator-controller image so we don't need to use the rukpak image. Signed-off-by: dtfranz <dfranz@redhat.com> * ✨ OPRUN-3293 Fixes several unit tests - not cache ones (#831) * Fix, rm or skip BundleDeployment related tests Signed-off-by: Brett Tofel <btofel@redhat.com> * Address lint errors Signed-off-by: Brett Tofel <btofel@redhat.com> --------- Signed-off-by: Brett Tofel <btofel@redhat.com> * Fix e2e (#843) Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com> * Make goreleaser build unpack Signed-off-by: Brett Tofel <btofel@redhat.com> * Rm commented code Signed-off-by: Brett Tofel <btofel@redhat.com> * Rebase required changes Signed-off-by: Brett Tofel <btofel@redhat.com> * Cleanups (#854) Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com> * Expand comments in Dockerfile Signed-off-by: Brett Tofel <btofel@redhat.com> * Address Reviews Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com> * Back out packagerrors It's agreed that this makes debugging and reasoning about log messages and runtime errors much harder. Signed-off-by: Brett Tofel <btofel@redhat.com> * Helm POC e2e fixes (#870) Fixes the e2e tests in helm-poc branch and restores feature-gate switching. Signed-off-by: dtfranz <dfranz@redhat.com> * Fix defer location (#883) Fixes the defer location to make sure that all resources are cleaned up properly. Signed-off-by: dtfranz <dfranz@redhat.com> * Remove BundleDeployments gathering from e2e's gatherArtifacts (#886) When tests fail, gatherArtifacts is run to collect cluster state. This PR removes gathering of BundleDeployments since we don't use them anymore and it's generating additional misleading error messages. Signed-off-by: dtfranz <dfranz@redhat.com> * Address reviews (#887) Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com> * 🌱 Proposed way to unskip some tests (#874) * Proposed way to unskip some tests TestClusterExtensionChannelVersionExists mostly restored here Signed-off-by: Brett Tofel <btofel@redhat.com> * Refactors global variable names Signed-off-by: Brett Tofel <btofel@redhat.com> * Removes BundleDeployment related checking In just one test, for now. Signed-off-by: Brett Tofel <btofel@redhat.com> * fix unit test - TestClusterExtensionChannelVersionExists * Unskip all - failing tests (up|down)grade should err Unskips all in clusterextension_controller_test.go Signed-off-by: Brett Tofel <btofel@redhat.com> * Unskip all clusterextension_registryv1_validation_test.go Still failing tests (up|down)grade should err b/c we don't have an installedBundle to check against Signed-off-by: Brett Tofel <btofel@redhat.com> * debugging Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com> * Fixes and additions pending & unpack path Signed-off-by: Brett Tofel <btofel@redhat.com> * Fix linter, remove debug logs and extraneous file Signed-off-by: dtfranz <dfranz@redhat.com> * Fix e2e failure due to race condition Signed-off-by: dtfranz <dfranz@redhat.com> --------- Signed-off-by: Brett Tofel <btofel@redhat.com> Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com> Signed-off-by: dtfranz <dfranz@redhat.com> Co-authored-by: Varsha Prasad Narsing <varshaprasad96@gmail.com> Co-authored-by: dtfranz <dfranz@redhat.com> * Revert goreleaser to use buildx Signed-off-by: Brett Tofel <btofel@redhat.com> * Revert all of goreleaser to use buildx Signed-off-by: Brett Tofel <btofel@redhat.com> * Revert errorf->printf & rm some logging in tests Signed-off-by: Brett Tofel <btofel@redhat.com> --------- Signed-off-by: dtfranz <dfranz@redhat.com> Signed-off-by: Brett Tofel <btofel@redhat.com> Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com> Co-authored-by: Todd Short <tshort@redhat.com> Co-authored-by: Daniel Franz <dfranz@redhat.com> Co-authored-by: Varsha <varshaprasad96@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes e2e!
go.modneeds to be updated to after operator-framework/rukpak#884 gets merged.Reviewer Checklist