Skip to content

Bentito helm poc - #894

Closed
dtfranz wants to merge 9 commits into
operator-framework:helm-pocfrom
dtfranz:bentito_helm-poc
Closed

Bentito helm poc#894
dtfranz wants to merge 9 commits into
operator-framework:helm-pocfrom
dtfranz:bentito_helm-poc

Conversation

@dtfranz

Copy link
Copy Markdown
Contributor

No description provided.

@dtfranz
dtfranz requested a review from a team as a code ownerMay 28, 2024 19:28
bentitoand others added 8 commits May 28, 2024 12:35
TestClusterExtensionChannelVersionExists mostly restored here
Signed-off-by: Brett Tofel <btofel@redhat.com>
Signed-off-by: Brett Tofel <btofel@redhat.com>
In just one test, for now.
Signed-off-by: Brett Tofel <btofel@redhat.com>
Unskips all in clusterextension_controller_test.go
Signed-off-by: Brett Tofel <btofel@redhat.com>
Still failing tests (up|down)grade should err b/c we don't have an installedBundle to check against
Signed-off-by: Brett Tofel <btofel@redhat.com>
Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
Signed-off-by: Brett Tofel <btofel@redhat.com>
Signed-off-by: dtfranz <dfranz@redhat.com>
@codecov

codecovBot commented May 28, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 44.87179% with 43 lines in your changes are missing coverage. Please review.

Project coverage is 58.52%. Comparing base (b993945) to head (507c86e).

FilesPatch %Lines
internal/controllers/common_controller.go51.02%24 Missing ⚠️
...nternal/controllers/clusterextension_controller.go26.92%19 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## helm-poc #894 +/- ##
=============================================
- Coverage 76.08% 58.52% -17.56% 
=============================================
Files 18 11 -7 Lines 1154 991 -163 =============================================
- Hits 878 580 -298 - Misses 198 378 +180 + Partials 78 33 -45 
FlagCoverage Δ
e2e?
unit58.52% <44.87%> (+7.33%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmshort

tmshort commented May 29, 2024

Copy link
Copy Markdown
Contributor

Closing in favor of #874

@tmshorttmshort closed this May 29, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@dtfranz@tmshort@bentito@varshaprasad96