Skip to content

🌱 Change global var GetInstalledBundle to interface - #899

Merged
bentito merged 1 commit into
operator-framework:mainfrom
bentito:rm-globalvar-getbundle
May 30, 2024
Merged

🌱 Change global var GetInstalledBundle to interface#899
bentito merged 1 commit into
operator-framework:mainfrom
bentito:rm-globalvar-getbundle

Conversation

@bentito

Copy link
Copy Markdown
Contributor

Description

Follow on to the helm-poc changes:

We'd like to not have a global variable for GetInstalledBundle, but instead an easier to test interface.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Brett Tofel <btofel@redhat.com>
@bentito
bentito requested a review from a team as a code ownerMay 30, 2024 19:57
@netlify

netlifyBot commented May 30, 2024

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit93b05e0
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/6658da407ed49e0008c6a218
😎 Deploy Previewhttps://deploy-preview-899--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov

codecovBot commented May 30, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.21%. Comparing base (0058054) to head (93b05e0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #899 +/- ##
==========================================
- Coverage 77.21% 76.21% -1.01% 
==========================================
Files 17 17 Lines 1176 1177 +1 ==========================================
- Hits 908 897 -11 - Misses 189 202 +13 + Partials 79 78 -1 
FlagCoverage Δ
e2e58.19% <100.00%> (-1.67%)⬇️
unit58.02% <50.00%> (-0.51%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bentito
bentito added this pull request to the merge queue May 30, 2024
Merged via the queue into operator-framework:main with commit b282b12May 30, 2024
@varshaprasad96varshaprasad96 mentioned this pull request May 31, 2024
11 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@bentito@everettraven