Uh oh!
There was an error while loading. Please reload this page.
The "description" method has been corrected - #104
Open
SMI-82 wants to merge 5 commits into
Open
Conversation
sorinsarca
left a comment
Member
There was a problem hiding this comment.
Hello @SMI-82, thank you for your contribution!
I would like to bring to your attention a few things:
- one pull-request per feature, I usually don't merge multiple unreleated changes
- make sure you don't break backward compatibility
- add tests for your changes
- it is always better to discuss if something should be added (open an issue)
This project supports multiple database systems (MySQL, PostgreSQL, Microsoft SQL, SQLite, etc.) but most of your features are MySQL only.
You can find more details in the review attached to this PR.
| /** | ||
| * @return $this | ||
| */ | ||
| public function nullable(): self |
Member
There was a problem hiding this comment.
Columns are nullable by default, this is redundant.
| * @param string $value | ||
| * @return $this | ||
| */ | ||
| public function collate(string $value): self |
Member
There was a problem hiding this comment.
Different DBs use different values for COLLATE.
| /** | ||
| * @return $this | ||
| */ | ||
| public function onUpdateCurrentTimeStamp(): self |
Member
There was a problem hiding this comment.
MySQL specific.
You can implement this in most DBs using a TRIGGER.
| * @return string | ||
| */ | ||
| protected function handleModifierComment(BaseColumn $column): string | ||
| { |
| * @return $this | ||
| */ | ||
| public function timestamps(string $createColumn = 'created_at', string $updateColumn = 'updated_at'): self | ||
| public function timestamps($fields = []): self |
| * @param BaseColumn $column | ||
| * @return string | ||
| */ | ||
| protected function handleModifierOnUpdateCurrentTimeStamp(BaseColumn $column): string |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! 👋
I’d like to contribute to your project. This pull request includes a few fixes that improve the functionality. Looking forward to your feedback!