Skip to content

logic of BatcherSubmitter - #37

Merged
GrapeBaBa merged 1 commit into
optimism-java:mainfrom
thinkAfCod:batcher
Aug 10, 2023
Merged

logic of BatcherSubmitter#37
GrapeBaBa merged 1 commit into
optimism-java:mainfrom
thinkAfCod:batcher

Conversation

@thinkAfCod

@thinkAfCodthinkAfCod commented Aug 4, 2023

Copy link
Copy Markdown
Collaborator

GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment threadhildr-batcher/src/main/java/io/optimism/batcher/publisher/ChannelDataPublisher.java Outdated
GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment threadhildr-batcher/src/main/java/io/optimism/batcher/publisher/ChannelDataPublisher.java Outdated
GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment threadhildr-batcher/src/main/java/io/optimism/batcher/loader/BlockLoader.java Outdated
GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment threadhildr-batcher/src/main/java/io/optimism/batcher/loader/BlockLoader.java Outdated
l2Client.ethGetBlockByNumber(DefaultBlockParameter.valueOf(number), true);
EthBlock.Block block;
try (var scope = new StructuredTaskScope.ShutdownOnFailure()) {
var blockFur = scope.fork(ethBlockRequest::send);

@GrapeBaBaGrapeBaBaAug 8, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blockFur这个缩写不对吧

GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment threadhildr-batcher/src/main/java/io/optimism/batcher/loader/BlockLoader.java
GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment threadhildr-batcher/src/main/java/io/optimism/batcher/loader/BlockLoader.java
GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment threadhildr-batcher/src/main/java/io/optimism/batcher/loader/BlockLoader.java
GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment threadhildr-batcher/src/main/java/io/optimism/batcher/loader/BlockLoader.java Outdated
GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment threadhildr-batcher/src/main/java/io/optimism/batcher/loader/BlockLoader.java
GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment threadhildr-batcher/src/main/java/io/optimism/batcher/loader/BlockLoader.java Outdated
GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment threadhildr-batcher/src/main/java/io/optimism/batcher/loader/BlockLoader.java Outdated
GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment threadhildr-batcher/src/main/java/io/optimism/batcher/loader/BlockLoader.java Outdated
GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment threadhildr-batcher/src/main/java/io/optimism/batcher/channel/ChannelManager.java Outdated
GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment threadhildr-batcher/src/main/java/io/optimism/batcher/BatcherSubmitter.java
GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment threadhildr-batcher/src/main/java/io/optimism/batcher/BatcherSubmitter.java Outdated
GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment threadhildr-batcher/src/main/java/io/optimism/batcher/BatcherSubmitter.java Outdated
@thinkAfCod
thinkAfCodforce-pushed the batcher branch 8 times, most recently from 0a24d2f to 9077af1CompareAugust 9, 2023 01:59
@GrapeBaBa
GrapeBaBa merged commit 8776142 into optimism-java:mainAug 10, 2023
@thinkAfCodthinkAfCod mentioned this pull request Aug 11, 2023
Merged
@thinkAfCod
thinkAfCod deleted the batcher branch August 16, 2023 08:50
@thinkAfCodthinkAfCod mentioned this pull request Aug 16, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GrapeBaBaGrapeBaBaGrapeBaBa left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thinkAfCod@GrapeBaBa