Uh oh!
There was an error while loading. Please reload this page.
docs(openapi): Fix documented response code - #227
Merged
Conversation
The current API spec is out of date with the existing implementation. `/track` returns an HTTP 200 and not a 204. The change was made as part of [this](70300ad#diff-792ff1ebb42545c5d3e4b34233906b27L75-R70) commit, but the spec was not updated.
Codecov Report
@@ Coverage Diff @@## master #227 +/- ##
=======================================
Coverage 82.55% 82.55% =======================================
Files 27 27 Lines 1261 1261 =======================================
Hits 1041 1041 Misses 165 165 Partials 55 55
Continue to review full report at Codecov.
|
mjc1283
approved these changes
May 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The current API spec is out of date with the existing implementation.
/trackreturns an HTTP 200 and not a 204. The change was made as part of this commit, but the spec was not updated.