Skip to content

ci: Added coveralls - #250

Merged
mikeproeng37 merged 3 commits into
masterfrom
sohail/replacecodecove
Jul 16, 2020
Merged

ci: Added coveralls#250
mikeproeng37 merged 3 commits into
masterfrom
sohail/replacecodecove

Conversation

@msohailhussain

@msohailhussainmsohailhussain commented Jul 14, 2020

Copy link
Copy Markdown
Contributor

Summary

  • Replaced codecove.io to coveralls.

TestPlan

  • All UT and FSC must pass
  • Check should be available for coveralls.

@msohailhussainmsohailhussain changed the title WIP - test coverallsci: Added coverallsJul 15, 2020
@msohailhussain
msohailhussain marked this pull request as ready for review July 15, 2020 17:25

@mikeproeng37mikeproeng37 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also replace our badge in the README:

Coverage Status

@mikeproeng37mikeproeng37 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37
mikeproeng37 merged commit 449c3d5 into masterJul 16, 2020
@mikeproeng37
mikeproeng37 deleted the sohail/replacecodecove branch July 16, 2020 00:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@msohailhussain@mikeproeng37