Skip to content

[docs] adding versioned docs to travis; update v4.0 markdown docs for Raptor/Decide release - #296

Merged
fscelliott merged 12 commits into
masterfrom
docs-decide
Apr 15, 2021
Merged

[docs] adding versioned docs to travis; update v4.0 markdown docs for Raptor/Decide release#296
fscelliott merged 12 commits into
masterfrom
docs-decide

Conversation

@fscelliott

@fscelliottfscelliott commented Jan 18, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

For the Decide API and Raptor releases:

  • introduced versioning to the docs
  • updated the terminology + added decide call to docs (see especially this commit for a diff: c937c98 )
    OTHER NOTES for reviewers:
  • the openapi spec will also need to be updated!
  • I don't read GO super well so please review my docs carefully in c937c98; I may have made errors, I was just going off looking at the Decide PR diffs.
  • I don't know if the /datafile endpoint is also going to be part of the Decide release but if so it will also need docs/openapi updates!

Issues

@fscelliottfscelliott changed the title adding versioned docs infrastructure[docs] adding versioned docs to travis; update v4.0 docs for Raptor/DecideJan 19, 2021
@fscelliottfscelliott changed the title [docs] adding versioned docs to travis; update v4.0 docs for Raptor/Decide[docs] adding versioned docs to travisJan 19, 2021
@fscelliottfscelliott changed the title [docs] adding versioned docs to travis[docs] adding versioned docs to travis; update v4.0 markdown docs for Raptor/Decide releaseJan 19, 2021
@fscelliottfscelliott mentioned this pull request Mar 1, 2021
Closed
yasirfolio3
yasirfolio3 suggested changes Mar 2, 2021
View reviewed changes

@yasirfolio3yasirfolio3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, have made some minor comments.

Comment threaddocs/readme-sync/v4.0/deploy-as-a-microservice/010 - optimizely-agent.md Outdated
Comment threaddocs/readme-sync/v4.0/deploy-as-a-microservice/012 - quickstart-for-agent.md Outdated
Comment thread...me-sync/v4.0/deploy-as-a-microservice/030 - use-optimizely-agent/010 - evaluate-rest-apis.md Outdated
Comment threaddocs/readme-sync/v4.0/deploy-as-a-microservice/012 - quickstart-for-agent.md Outdated
Comment threaddocs/readme-sync/v4.0/deploy-as-a-microservice/030 - use-optimizely-agent/index.md Outdated
Comment threaddocs/readme-sync/v4.0/deploy-as-a-microservice/030 - use-optimizely-agent/index.md Outdated
Comment thread...e-sync/v4.0/deploy-as-a-microservice/040 - configure-optimizely-agent/010 - authorization.md Outdated
Mat001
Mat001 requested changes Mar 10, 2021
View reviewed changes

@Mat001Mat001 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fscelliott Out of curiosity, changes to these examples are not included in this PR: https://github.com/optimizely/agent/tree/master/examples ?
I don't see the changes, except to authentication. Are they not supposed to be part of this PR?

Comment threaddocs/readme-sync/v4.0/deploy-as-a-microservice/030 - use-optimizely-agent/index.md Outdated
@fscelliott
fscelliott requested review from Mat001 and yasirfolio3 and removed request for mjc1283March 15, 2021 22:00
Mat001
Mat001 approved these changes Mar 23, 2021
View reviewed changes
Comment threaddocs/readme-sync/v4.0/deploy-as-a-microservice/030 - use-optimizely-agent/020 - admin-api.md
Comment threaddocs/readme-sync/v4.0/deploy-as-a-microservice/030 - use-optimizely-agent/020 - admin-api.md
@fscelliott
fscelliott requested review from yasirfolio3 and removed request for yasirfolio3March 23, 2021 18:05
yasirfolio3
yasirfolio3 approved these changes Mar 24, 2021
View reviewed changes

@yasirfolio3yasirfolio3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fscelliott
fscelliott merged commit e0d4d31 into masterApr 15, 2021
@fscelliott
fscelliott deleted the docs-decide branch April 15, 2021 19:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mat001Mat001Mat001 approved these changes
+1 more reviewer
@yasirfolio3yasirfolio3yasirfolio3 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fscelliott@Mat001@yasirfolio3