Skip to content

Fix: build was not triggering on pushing tags - #360

Merged
msohailhussain merged 6 commits into
masterfrom
mnoman/gitactionfix
Feb 28, 2023
Merged

Fix: build was not triggering on pushing tags#360
msohailhussain merged 6 commits into
masterfrom
mnoman/gitactionfix

Conversation

@mnoman09

@mnoman09mnoman09 commented Feb 28, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • fixed the regex to validate the tags value

@mnoman09mnoman09 self-assigned this Feb 28, 2023
@mnoman09mnoman09 changed the title testFix: build was not triggering on pushing tagsFeb 28, 2023
msohailhussain
msohailhussain approved these changes Feb 28, 2023
View reviewed changes

@msohailhussainmsohailhussain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msohailhussain
msohailhussain merged commit 54b5f1e into masterFeb 28, 2023
@msohailhussain
msohailhussain deleted the mnoman/gitactionfix branch February 28, 2023 19:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@msohailhussainmsohailhussainmsohailhussain approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mnoman09mnoman09

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mnoman09@msohailhussain@NomanShoaib