Uh oh!
There was an error while loading. Please reload this page.
Deserialize integers as longs when using Gson - #623
Open
jamiesanson wants to merge 4 commits into
Open
Conversation
jamiesansonforce-pushed
the
js/gson-deserialize-integers
branch
from
May 6, 2026 09:27
c3bc3c2 to
1062edfCompareFarhanAnjum-opti
commented
May 6, 2026
Contributor
Hi @jamiesanson, thanks for submitting this and putting in the work on the code. Before we can bring your PR into our workflow, please sign the CLA here . Once that’s done, we’ll be able to move forward. |
FarhanAnjum-opti
commented
May 7, 2026
Contributor
@jamiesanson, once you’ve signed the form, could you please confirm here on the PR as well for future reference? You can just comment something like "Signed". |
jamiesanson
commented
May 7, 2026
Author
Ah of course! Signed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deserialize integers as longs when using Gson. This allows users to then use the resultant
Mapin downstream serializers more easily.Note: This is a breaking change in the case where consumers were relying on the double output. It's more correct, so feels worth taking, but feel free to hold this PR until you plan to release a new major version!
Issues
Fixes#622