Uh oh!
There was an error while loading. Please reload this page.
feat: bump java clients openapi-generator to 6.0.0 - #192
Conversation
aeneasr
commented
Jun 21, 2022
Thank you! :) Are there breaking changes in the 6.0 generate that we need to be aware of? |
You are welcome =) |
aeneasr
commented
Jun 21, 2022
Great, thanks! |
aeneasr
commented
Jun 22, 2022
Hi, I'm just echoing my message from slack: Hi Lucas, thank you! I think the info that they fixed an important bug is enough for me to get it merged 🙂 For breaking changes, you can also always look at the release change log from open api generator itself: https://github.com/OpenAPITools/openapi-generator/releases/tag/v6.0.0#java One last thing we need to do though is that we probably need to update the dependencies to match the 6.0 generator here: https://github.com/ory/sdk/tree/master/contrib/poms When I upgraded to 5.4.0 these were the changes I had to make (please only look at the POM changes): Regarding the question you had on slack, https://github.com/ory/sdk#debugging-failing-circleci-tests This will generate the code in your local file system! |
geetparekh
commented
Jun 29, 2022
Hello, Curious as to in which version will the fix be available. We are also facing the same issue when calling Hydra Admin API to accept logout request. Thank you! |
aeneasr
commented
Oct 24, 2022
We updated the java generator |

Context :
A bug has been fixed in the release 6.0.0 of openapi-generator.
It fixes a NPE when trying to perform a PUT with an empty body while using the ApiClient generated with openapi-generator.
Link to the fix on openapi-generator : OpenAPITools/openapi-generator#12172
In my case I am having this error when calling Hydra Admin API to accept logout request. It is building a PUT request with an empty body and it ends up with a NPE.
Idea is to upgrade openapi-generator version to include the fix in generated ory/hydra-client-java.
For a more detailed overview of the bug I have created a ticket on ory/sdk repository that is mentionent below (in Related Issue or Design Document part)
Related Issue or Design Document
Linked to bug ticket on ory/sdk : #191
Checklist
vulnerability, I confirm that I got green light (please contact security@ory.sh) from the
maintainers to push the changes.
Further comments