Feature/project matrix - #123
Open
idans124 wants to merge 21 commits into
Open
Conversation
ranbentzvi
suggested changes
Apr 1, 2020
| return Matrix(list2tuple) | ||
| def __eq__(self, other): | ||
| return self.my_list == other.my_list |
There was a problem hiding this comment.
if the other object isn't matrix? and don't have my_list?
| __rmul__ = __mul__ | ||
| def __sub__(self, other): |
There was a problem hiding this comment.
the sub and the add function look quite similar, try to unify them
| # ========== list to tuple =============== | ||
| for index in range(dim): | ||
| new_list[index] = (*new_list[index],) | ||
| list2tuple = (*new_list,) |
There was a problem hiding this comment.
you can skip this and just send (*new_list,) to the matrix creation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.