Matrix exercise - #127
Open
mayareu wants to merge 5 commits into
Open
Conversation
ranbentzvi
suggested changes
Apr 1, 2020
| return self.__matrix | ||
| def scalar_multiplication(self, scalar): | ||
| result = [tuple(map(lambda x: x * scalar, i)) for i in self.__matrix] |
There was a problem hiding this comment.
the use of map and lambda is not recommended, please change that
| result = [tuple(map(lambda x: x * scalar, i)) for i in self.__matrix] | ||
| return tuple(result) | ||
| def addition(self, other_matrix): |
There was a problem hiding this comment.
your addition and subtraction look quite similar, think of a way to unify them
| def get_size(self): | ||
| return self.__matrix.__len__() | ||
| def compare(self, other_matrix): |
There was a problem hiding this comment.
if the other object type is not matrix?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.