Skip to content

commit atm - #140

Open
kerenkay wants to merge 5 commits into
osherdp:masterfrom
kerenkay:feature/ATM
Open

commit atm#140
kerenkay wants to merge 5 commits into
osherdp:masterfrom
kerenkay:feature/ATM

Conversation

@kerenkay

@kerenkaykerenkay commented Apr 5, 2020

Copy link
Copy Markdown
Collaborator

No description provided.

@kerenkaykerenkay closed this Apr 5, 2020
@kerenkaykerenkay reopened this Apr 5, 2020
natsala13
natsala13 requested changes Apr 6, 2020
View reviewed changes
Comment threadATM.py Outdated
Comment threadATM.py Outdated
Comment threadATM.py Outdated
Comment threadATM.py Outdated
Comment threadATM.py Outdated
Comment threadATM.py Outdated
Comment threadATM.py Outdated
Comment threadATM.py Outdated
Comment threadATM.py Outdated
Comment threadATM.py Outdated
jhb1996
jhb1996 reviewed Apr 6, 2020
View reviewed changes
Comment threadATM.py Outdated
Comment threadATM.py Outdated
Comment threadATM.py Outdated
IgalKolihman
IgalKolihman requested changes Apr 6, 2020
View reviewed changes
Comment threadATM.py Outdated
Comment threadATM.py Outdated
Comment threadATM.py Outdated
Comment threadATM.py Outdated
Comment threadATM.py Outdated
Comment threadATM.py Outdated
Comment threadATM.py Outdated
Comment threadATM.py Outdated
@rfire01

rfire01 commented Apr 6, 2020

Copy link
Copy Markdown
Collaborator

make sure flake 8 pass

natsala13
natsala13 requested changes Apr 6, 2020
View reviewed changes
Comment threadATM.py
Comment threadATM.py
rfire01
rfire01 requested changes Apr 7, 2020
View reviewed changes
Comment threadATM.py
Comment threadATM.py
Comment threadATM.py
with open(filename, 'r') as file:
for line in file:
details = line.strip().split(' ')
atm[details[ID_INDEX]] = details[INDEX_START_OF_PASSWORD_AND_BALANCE:]

@rfire01rfire01Apr 7, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saving the data as list isn't a good practice.
What happen if you change the way the data look? you need to change everywhere you use it the indexes of each part.
Instead the only place that should be effect is the read file function

Comment threadATM.py
Comment threadATM.py
Comment threadATM.py
Comment threadATM.py
Comment threadATM.py
Comment threadATM.py
Comment threadATM.py
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhb1996jhb1996jhb1996 left review comments
@rfire01rfire01rfire01 requested changes
@natsala13natsala13natsala13 requested changes
@IgalKolihmanIgalKolihmanIgalKolihman requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kerenkay@rfire01@jhb1996@natsala13@IgalKolihman