Calculator Exercise by yonatanevantal · Pull Request #146 · osherdp/python-training

yonatanevantal · 2020-04-21T13:03:06Z

No description provided.

jacksonpc2 · 2020-04-23T07:05:01Z

+import math
+import operator
+import re
+from collections import namedtuple
+from sys import maxsize


jacksonpc2 · 2020-04-23T07:06:01Z

+# higher precedence means the operator stronger (will be done first)
+Operator = namedtuple("Operator", ["operation", "precedence", "regex"])


jacksonpc2 · 2020-04-23T07:06:42Z

+OPERATORS = {
+ '+': Operator(precedence=1, operation=operator.add,
+ regex=fr"({ANY_NUMBER})\+({ANY_NUMBER})"),
+ '-': Operator(precedence=1, operation=operator.sub,
+ regex=fr"({ANY_NUMBER})-({ANY_NUMBER})"),
+
+ '*': Operator(precedence=2, operation=operator.mul,
+ regex=fr"({ANY_NUMBER})\*({ANY_NUMBER})"),
+ '/': Operator(precedence=2, operation=operator.truediv,
+ regex=fr"({ANY_NUMBER})/({ANY_NUMBER})"),
+
+ '^': Operator(precedence=3, operation=math.pow,
+ regex=fr"({ANY_NUMBER})\^({ANY_NUMBER})"),
+ '%': Operator(precedence=4, operation=math.fmod,
+ regex=fr"({ANY_NUMBER})%({ANY_NUMBER})"),
+
+ '@': Operator(precedence=5, operation=lambda x, y: (x + y) / 2.0,
+ regex=fr"({ANY_NUMBER})@({ANY_NUMBER})"),
+ '$': Operator(precedence=5, operation=max,
+ regex=fr"({ANY_NUMBER})\$({ANY_NUMBER})"),
+ '&': Operator(precedence=5, operation=min,
+ regex=fr"({ANY_NUMBER})&({ANY_NUMBER})"),
+
+ '~': Operator(precedence=6, operation=operator.neg,
+ regex=fr"~({ANY_NUMBER})"),
+ '!': Operator(precedence=7, operation=math.factorial,
+ regex=fr"({ANY_NUMBER})!"),
+
+ '(': Operator(precedence=maxsize, operation=lambda expr: _evaluate(expr),


Why is this a dict?

jacksonpc2 · 2020-04-23T07:08:43Z

+def operators_info_by_precedence() -> list:
+ """Sort the value of each item in OPERATORS by its priority.
+
+ Returns:
+ List of Operator named tuples by priority, strong to weak.
+ """
+ return sorted(OPERATORS.values(), key=operator.attrgetter("precedence"),
+ reverse=True)
+
+
+def replace_in_expression(operator_regex: str, expression: str,
+ new_expr: str) -> str:
+ """Change the old sub expression to a new one according to pattern.
+
+ Args:
+ operator_regex: pattern to find a sub expression of the operator.
+ expression: the entire expression.
+ new_expr: the expression to put instead of the old one.
+
+ Returns:
+ A new whole expression, changed according to pattern.
+ """
+ old_expression = re.search(operator_regex, expression).group()
+ return expression.replace(old_expression, new_expr)


Both of this functions seems redundant.
Just inline those lines, its simple enough and clear.

jacksonpc2 · 2020-04-23T07:18:39Z

+ if operator_info.precedence != maxsize:
+ operands = list(map(float, operands))
+
+ result = operator_info.operation(*operands)


Nice! thats more like it 👍

jacksonpc2 · 2020-04-23T07:20:07Z

+ operator_regex, expression, str(result))
+
+ return _evaluate(expression)
+ return float(expression)


newline (conventions)

jacksonpc2 · 2020-04-23T07:20:26Z

+ raw_expression = input(USER_MSG)
+
+ while raw_expression.lower() != "quit":
+ print(_evaluate(raw_expression))
+ raw_expression = input(USER_MSG)


read about iter

jacksonpc2 · 2020-04-23T07:21:40Z

+
+
+class TestEdgeCases(unittest.TestCase):
+ """Test rare cases of inputs to see function behavior"""


dot in the end of the line.

jacksonpc2 · 2020-04-23T07:33:04Z

+ with self.assertRaises(ValueError):
+ _evaluate('1+a*76')
+


Check the output of the expression : -1-2*-2

yonatanevantal added 7 commits March 25, 2020 17:48

Remove spaces and operators structure
42a4ee9

Added inner parentheses function
c3a57ba

Different methods for most inner parentheses
eafc74c

before debugging
eb5061a

First working stable version
8a27fe3

Deleted sandbox
f0587c5

Added unit tests
926a1e5

yonatanevantal self-assigned this Apr 21, 2020

Finished unit tests and simplification
e4cc0e8

NivosMagnivos reviewed Apr 21, 2020
View reviewed changes

rfire01 requested changes Apr 21, 2020
View reviewed changes

yairigal suggested changes Apr 21, 2020
View reviewed changes

Simplification and edge cases
403fcb1

NivosMagnivos suggested changes Apr 22, 2020
View reviewed changes

jacksonpc2 suggested changes Apr 23, 2020
View reviewed changes

yairigal suggested changes Apr 23, 2020
View reviewed changes

yonatanevantal added 4 commits April 23, 2020 16:18

Iter and inlining
a324e6d

Checking more edge cases and generic code
56485ad

Remove unused function and imports order
8897725

Condition simplification
6c5da73

yairigal suggested changes Apr 23, 2020
View reviewed changes

Comment threadcalculator/calculator.py Outdated
Comment threadcalculator/calculator.py Outdated
Comment threadcalculator/calculator.py Outdated
Comment threadcalculator/calculator.py Outdated
Comment threadcalculator/calculator.py Outdated

yonatanevantal added 2 commits April 23, 2020 20:42

Partial and fullmatch
44f85c7

Convention
2617ba6

yairigal approved these changes Apr 23, 2020
View reviewed changes

Merge branch 'osherdp:master' into yonatan/calculator
ac5eef1

		# higher precedence means the operator stronger (will be done first)
		Operator = namedtuple("Operator", ["operation", "precedence", "regex"])



		class TestEdgeCases(unittest.TestCase):
		"""Test rare cases of inputs to see function behavior"""

Conversation

yonatanevantal commented Apr 21, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees