Explicitly export exception types.

[oraluben]

This should fixosmcode/pyosmium#165

Ref: pybind/pybind11#2999, GCC Wiki

[codecov-commenter]

Codecov Report

Merging #332 (81d16d9) into master (b263ba5) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #332 +/- ##
=======================================
Coverage 79.25% 79.25% =======================================
Files 282 282 Lines 20712 20712 =======================================
Hits 16416 16416 Misses 4296 4296 

Flag	Coverage Δ
data_tests	56.50% <ø> (ø)
examples	51.57% <ø> (ø)
unit_tests	75.13% <ø> (-0.08%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
include/osmium/geom/factory.hpp	97.45% <ø> (ø)
include/osmium/geom/util.hpp	100.00% <ø> (ø)
include/osmium/handler/check_order.hpp	93.75% <ø> (ø)
include/osmium/index/index.hpp	50.00% <ø> (ø)
include/osmium/index/map.hpp	86.84% <ø> (ø)
include/osmium/io/error.hpp	100.00% <ø> (ø)
include/osmium/memory/buffer.hpp	74.27% <ø> (ø)
include/osmium/osm/item_type.hpp	26.53% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b263ba5...81d16d9. Read the comment docs.

[oraluben]

Working on CI failure.

I'm not able to reproduce the CI failures, would someone have any hint about what happened?

[joto]

Looks to me like you probably didn't include the compatibility.hpp everywhere that's needed. For instance in include/osmium/memory/buffer.hpp.

[oraluben]

Looks to me like you probably didn't include the compatibility.hpp everywhere that's needed. For instance in include/osmium/memory/buffer.hpp.

Thanks for your reply! They already included the file (e.g. in buffer.hpp), and I also successfully compiled the project. Is there anything different I should notice between local and the CI's environment?

[joto]

I have merged this now (in slightly different form). Sorry it took so long, but I needed to understand what's happening here first.

[joto]

Because VS is generating warnings I wrapped the code defining OSMIUM_EXPORT into an #ifdef OSMIUM_DEFINE_EXPORT. So you have to compile with -DOSMIUM_DEFINE_EXPORT if you need this functionality. Can you provide a PR for Pyosmium if that works for you?

[oraluben]

@joto thanks! I'll try to draft a PR there.