Uh oh!
There was an error while loading. Please reload this page.
Sync with upstream dashing branch - #48
Merged
Merged
Conversation
jacobperronforce-pushed
the
jacob/from_upstream
branch
3 times, most recently
from
November 10, 2020 02:54
44903be to
deeef60Comparejacobperron
commented
Nov 10, 2020
Author
ivanpauno
approved these changes
Nov 10, 2020
…85) * Re-enable tests related to services Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Add Client methods for checking and waiting for service availability These methods are very useful for allowing a client to wait for a service to be available before making requests. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Refactor ClientTest to avoid repeatedly sending requests Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Generate action code for: * `<goal_name>_SendGoal_Request` * `<goal_name>_SendGoal_Response` * `<goal_name>_GetResult_Request` * `<goal_name>_GetResult_Response`
* clear node/context handle on RclJava.cleanup() * clear publishers, subscriptions, clients, services and timers on Node.dispose()
* Remove redundant code generation The request and response messages are already generated as part of the srv template. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Strip action service suffixes from C include prefix The generated C headers for actions are included in a single header named after the action. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Generate Java code for SendGoal and GetResult service definitions Though not strictly necessary, it is nice to have definitions for these action-specific services for the purpose of writing unit tests. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Compile generated service definitions for actions Previously, though we were generated service definitions for actions we were not compiling them. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperronforce-pushed
the
jacob/from_upstream
branch
from
November 10, 2020 17:19
deeef60 to
244d898Comparejacobperron
commented
Nov 10, 2020
Author
Rebased now that #50 is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks applicable changes from upstream's
dashingbranch:CI depends on #50