Skip to content

Add method to prune pending requests in client - #82

Merged
ivanpauno merged 3 commits into
galactic-develfrom
ivanpauno/prune-pending-requests
Nov 2, 2021
Merged

Add method to prune pending requests in client#82
ivanpauno merged 3 commits into
galactic-develfrom
ivanpauno/prune-pending-requests

Conversation

@ivanpauno

Copy link
Copy Markdown
Collaborator

Complements #81.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpaunoivanpauno added the enhancement New feature or request label Oct 28, 2021
@ivanpaunoivanpauno self-assigned this Oct 28, 2021
Comment on lines +41 to +43
long prunePendingRequests();

long prunePendingRequestsOlderThan(long nanoTime);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some docstrings describing these methods would be nice.

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in 24fbf81.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
ivanpauno merged commit bbed518 into galactic-develNov 2, 2021
@jacobperron
jacobperron deleted the ivanpauno/prune-pending-requests branch November 2, 2021 21:18
jacobperron pushed a commit to ros2-java/ros2_java that referenced this pull request May 17, 2022
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ivanpauno@jacobperron