Expect the optional GITHUB_READ_TOKEN secret binding in the plan profile - #94
Merged
Merged
Conversation
The live worker carries the read-only GitHub token secret installed with the identity fix; the promotion planner's pinned binding inventory must name it, else capture observation answers settings_drift.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The stage 04 promotion dispatch failed with
settings_drift: the planner's pinned binding inventory (commons_plan.settings()) did not name theGITHUB_READ_TOKENsecret that the live worker has carried since the identity fix (#92), so the capture observation could never match the expected profile.commons_plan.py: the pinned settings profile now includesGITHUB_READ_TOKEN: secret_text.commons_transition.py: the opaque-handles contract requires it alongside the other secrets.No worker, migration or schema changes; the candidate for
cebf351remains valid — after this merges, dispatch its promotion from the fresh rehearsal of the new head.Verification
plan / promotion / promotion-cli / transition / rehearsal / candidate / artifact suites all OK.