Add AequilibraE support - #1

Merged
tomstephen merged 77 commits into
masterfrom
tom/add-aeq-support
Jan 16, 2026
Merged

Add AequilibraE support#1
tomstephen merged 77 commits into
masterfrom
tom/add-aeq-support

Conversation

@tomstephen

Copy link
Copy Markdown

This PR adds AequilibraE support to SimWrapper. This involves,

  • new plugin at src/plugins/aequilibrae/...
  • registering plugin in src/plugins/pluginRegistry.ts
  • new panel (and registration) in src/dash-panels/aequilibrae.vue (and _allPanels.ts)
  • extension to the HTTPFileSystem.ts to add support for S3 buckets

In my testing I've modified a few other scripts (Splash, deploy scripts, etc) but we don't want to suggest merging these back to the original SimWrapper project, so I will revert. Additionally, current work needs a good refactor, particularly

  • SQLite queries could be leveraged better for speed (for loop over all rows currently)
  • much of the styling/rendering code could be replaced by calls to deck.gl

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 27 changed files in this pull request and generated 25 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

font-size: 1.4rem;
height: 5rem;
font-size: 2.5rem;
// height: 3.5rem;

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commented-out height property on line 318 (// height: 3.5rem;) should either be removed or uncommented if it's needed. Leaving commented code creates maintenance confusion.

Suggested change
// height: 3.5rem;

Copilot uses AI. Check for mistakes.
Comment threadpackage.json Outdated
Comment threadsrc/plugins/aequilibrae/db.ts Outdated
Comment threadsrc/plugins/aequilibrae/AequilibraEReader.vue Outdated
Comment threadsrc/plugins/sqlite-map/styling.ts Outdated
Comment on lines +85 to +113
const buildColorEncoder = (
values: any[],
style: any,
dataRange: [number, number] | null = null
) => {
if (dataRange) {
values = values.map(v => {
const num = toNumber(v)
if (num === null) return null
return Math.max(dataRange[0], Math.min(dataRange[1], num))
})
}

const nums = values.map(toNumber).filter((v): v is number => v !== null)
const s = style || {}
const [min, max] = s.range ? s.range : [safeMin(nums), safeMax(nums)]

const paletteName = s.palette || 'YlGn'
const numColors = s.numColors || 7
const colors = getPaletteColors(paletteName, numColors).map((h: string) => hexToRgba(h, 1))

const scale = max === min ? 0 : (numColors - 1) / (max - min)

return (value: any) => {
const num = toNumber(value) ?? min
const idx = Math.round((num - min) * scale)
return colors[Math.max(0, Math.min(numColors - 1, idx))]
}
}

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing input validation: the function buildColorEncoder doesn't validate that the palette name exists in cartoColors before accessing it. If an invalid palette name is provided, getPaletteColors will return an array of gray colors, which may not be the desired behavior. Consider adding validation or a more informative error message.

Copilot uses AI. Check for mistakes.
Comment threadsrc/plugins/aequilibrae/db.ts Outdated
Comment threadsrc/plugins/aequilibrae/useAequilibrae.ts Outdated
Comment on lines +27 to +34
import {
resolvePath,
resolvePaths,
getUsedColumns,
getNeededJoinColumn,
createJoinCacheKey,
hasGeometryColumn,
} from './utils'

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import getUsedColumns.

Copilot uses AI. Check for mistakes.
Comment on lines +257 to +264
// Create a cache key for this specific join query (for logging only)
const cacheKey = createJoinCacheKey(
joinConfig.database,
joinConfig.table,
neededColumn,
joinConfig.filter
)

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable cacheKey.

Suggested change
// Create a cache key for this specific join query (for logging only)
constcacheKey=createJoinCacheKey(
joinConfig.database,
joinConfig.table,
neededColumn,
joinConfig.filter
)

Copilot uses AI. Check for mistakes.
if (extraDb) {
// Centralized function will handle its own caching
joinedData = await getCachedJoinData(extraDb, joinConfig, neededColumn)
const colInfo = neededColumn ? ` (column: ${neededColumn})` : ''

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable colInfo.

Suggested change
const colInfo = neededColumn ? ` (column: ${neededColumn})` : ''

Copilot uses AI. Check for mistakes.
@tomstephen

Copy link
Copy Markdown
Author

Latest commit partially merges #3, we don't want every change so doing merge manually. Plan going forward is

  • extend sqlite-map with any extra features from POLARIS plugin we want
  • refactor POLARIS plugin to inherit from sqlite-map
  • split out the sql dashboarding features into a separate plugin
  • put together a combined aequilibrae and polaris test

* Extend tile.vue to support hard-coded key-value pairs, sqlite queries for said values, sqlite queries for entire table
* Full SQL support, either individual queries or a full table
* Add usage comment
* Colour palette-ing, defaults to original pastel palette
* Apply suggestions from review
@tomstephen
tomstephen marked this pull request as ready for review January 16, 2026 06:39
@tomstephen
tomstephen merged commit 9fbd3d8 into masterJan 16, 2026
1 check failed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tomstephen
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Add AequilibraE support - #1

Merged
tomstephen merged 77 commits into
masterfrom
tom/add-aeq-support
Jan 16, 2026
Merged

Add AequilibraE support#1
tomstephen merged 77 commits into
masterfrom
tom/add-aeq-support

Conversation

@tomstephen

Copy link
Copy Markdown

This PR adds AequilibraE support to SimWrapper. This involves,

  • new plugin at src/plugins/aequilibrae/...
  • registering plugin in src/plugins/pluginRegistry.ts
  • new panel (and registration) in src/dash-panels/aequilibrae.vue (and _allPanels.ts)
  • extension to the HTTPFileSystem.ts to add support for S3 buckets

In my testing I've modified a few other scripts (Splash, deploy scripts, etc) but we don't want to suggest merging these back to the original SimWrapper project, so I will revert. Additionally, current work needs a good refactor, particularly

  • SQLite queries could be leveraged better for speed (for loop over all rows currently)
  • much of the styling/rendering code could be replaced by calls to deck.gl

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 27 changed files in this pull request and generated 25 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

font-size: 1.4rem;
height: 5rem;
font-size: 2.5rem;
// height: 3.5rem;

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commented-out height property on line 318 (// height: 3.5rem;) should either be removed or uncommented if it's needed. Leaving commented code creates maintenance confusion.

Suggested change
// height: 3.5rem;

Copilot uses AI. Check for mistakes.
Comment threadpackage.json Outdated
Comment threadsrc/plugins/aequilibrae/db.ts Outdated
Comment threadsrc/plugins/aequilibrae/AequilibraEReader.vue Outdated
Comment threadsrc/plugins/sqlite-map/styling.ts Outdated
Comment on lines +85 to +113
const buildColorEncoder = (
values: any[],
style: any,
dataRange: [number, number] | null = null
) => {
if (dataRange) {
values = values.map(v => {
const num = toNumber(v)
if (num === null) return null
return Math.max(dataRange[0], Math.min(dataRange[1], num))
})
}

const nums = values.map(toNumber).filter((v): v is number => v !== null)
const s = style || {}
const [min, max] = s.range ? s.range : [safeMin(nums), safeMax(nums)]

const paletteName = s.palette || 'YlGn'
const numColors = s.numColors || 7
const colors = getPaletteColors(paletteName, numColors).map((h: string) => hexToRgba(h, 1))

const scale = max === min ? 0 : (numColors - 1) / (max - min)

return (value: any) => {
const num = toNumber(value) ?? min
const idx = Math.round((num - min) * scale)
return colors[Math.max(0, Math.min(numColors - 1, idx))]
}
}

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing input validation: the function buildColorEncoder doesn't validate that the palette name exists in cartoColors before accessing it. If an invalid palette name is provided, getPaletteColors will return an array of gray colors, which may not be the desired behavior. Consider adding validation or a more informative error message.

Copilot uses AI. Check for mistakes.
Comment threadsrc/plugins/aequilibrae/db.ts Outdated
Comment threadsrc/plugins/aequilibrae/useAequilibrae.ts Outdated
Comment on lines +27 to +34
import {
resolvePath,
resolvePaths,
getUsedColumns,
getNeededJoinColumn,
createJoinCacheKey,
hasGeometryColumn,
} from './utils'

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import getUsedColumns.

Copilot uses AI. Check for mistakes.
Comment on lines +257 to +264
// Create a cache key for this specific join query (for logging only)
const cacheKey = createJoinCacheKey(
joinConfig.database,
joinConfig.table,
neededColumn,
joinConfig.filter
)

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable cacheKey.

Suggested change
// Create a cache key for this specific join query (for logging only)
constcacheKey=createJoinCacheKey(
joinConfig.database,
joinConfig.table,
neededColumn,
joinConfig.filter
)

Copilot uses AI. Check for mistakes.
if (extraDb) {
// Centralized function will handle its own caching
joinedData = await getCachedJoinData(extraDb, joinConfig, neededColumn)
const colInfo = neededColumn ? ` (column: ${neededColumn})` : ''

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable colInfo.

Suggested change
const colInfo = neededColumn ? ` (column: ${neededColumn})` : ''

Copilot uses AI. Check for mistakes.
@tomstephen

Copy link
Copy Markdown
Author

Latest commit partially merges #3, we don't want every change so doing merge manually. Plan going forward is

  • extend sqlite-map with any extra features from POLARIS plugin we want
  • refactor POLARIS plugin to inherit from sqlite-map
  • split out the sql dashboarding features into a separate plugin
  • put together a combined aequilibrae and polaris test

* Extend tile.vue to support hard-coded key-value pairs, sqlite queries for said values, sqlite queries for entire table
* Full SQL support, either individual queries or a full table
* Add usage comment
* Colour palette-ing, defaults to original pastel palette
* Apply suggestions from review
@tomstephen
tomstephen marked this pull request as ready for review January 16, 2026 06:39
@tomstephen
tomstephen merged commit 9fbd3d8 into masterJan 16, 2026
1 check failed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tomstephen
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add AequilibraE support - #1

Merged
tomstephen merged 77 commits into
masterfrom
tom/add-aeq-support
Jan 16, 2026
Merged

Add AequilibraE support#1
tomstephen merged 77 commits into
masterfrom
tom/add-aeq-support

Conversation

@tomstephen

Copy link
Copy Markdown

This PR adds AequilibraE support to SimWrapper. This involves,

  • new plugin at src/plugins/aequilibrae/...
  • registering plugin in src/plugins/pluginRegistry.ts
  • new panel (and registration) in src/dash-panels/aequilibrae.vue (and _allPanels.ts)
  • extension to the HTTPFileSystem.ts to add support for S3 buckets

In my testing I've modified a few other scripts (Splash, deploy scripts, etc) but we don't want to suggest merging these back to the original SimWrapper project, so I will revert. Additionally, current work needs a good refactor, particularly

  • SQLite queries could be leveraged better for speed (for loop over all rows currently)
  • much of the styling/rendering code could be replaced by calls to deck.gl

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 27 changed files in this pull request and generated 25 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

font-size: 1.4rem;
height: 5rem;
font-size: 2.5rem;
// height: 3.5rem;

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commented-out height property on line 318 (// height: 3.5rem;) should either be removed or uncommented if it's needed. Leaving commented code creates maintenance confusion.

Suggested change
// height: 3.5rem;

Copilot uses AI. Check for mistakes.
Comment threadpackage.json Outdated
Comment threadsrc/plugins/aequilibrae/db.ts Outdated
Comment threadsrc/plugins/aequilibrae/AequilibraEReader.vue Outdated
Comment threadsrc/plugins/sqlite-map/styling.ts Outdated
Comment on lines +85 to +113
const buildColorEncoder = (
values: any[],
style: any,
dataRange: [number, number] | null = null
) => {
if (dataRange) {
values = values.map(v => {
const num = toNumber(v)
if (num === null) return null
return Math.max(dataRange[0], Math.min(dataRange[1], num))
})
}

const nums = values.map(toNumber).filter((v): v is number => v !== null)
const s = style || {}
const [min, max] = s.range ? s.range : [safeMin(nums), safeMax(nums)]

const paletteName = s.palette || 'YlGn'
const numColors = s.numColors || 7
const colors = getPaletteColors(paletteName, numColors).map((h: string) => hexToRgba(h, 1))

const scale = max === min ? 0 : (numColors - 1) / (max - min)

return (value: any) => {
const num = toNumber(value) ?? min
const idx = Math.round((num - min) * scale)
return colors[Math.max(0, Math.min(numColors - 1, idx))]
}
}

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing input validation: the function buildColorEncoder doesn't validate that the palette name exists in cartoColors before accessing it. If an invalid palette name is provided, getPaletteColors will return an array of gray colors, which may not be the desired behavior. Consider adding validation or a more informative error message.

Copilot uses AI. Check for mistakes.
Comment threadsrc/plugins/aequilibrae/db.ts Outdated
Comment threadsrc/plugins/aequilibrae/useAequilibrae.ts Outdated
Comment on lines +27 to +34
import {
resolvePath,
resolvePaths,
getUsedColumns,
getNeededJoinColumn,
createJoinCacheKey,
hasGeometryColumn,
} from './utils'

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import getUsedColumns.

Copilot uses AI. Check for mistakes.
Comment on lines +257 to +264
// Create a cache key for this specific join query (for logging only)
const cacheKey = createJoinCacheKey(
joinConfig.database,
joinConfig.table,
neededColumn,
joinConfig.filter
)

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable cacheKey.

Suggested change
// Create a cache key for this specific join query (for logging only)
constcacheKey=createJoinCacheKey(
joinConfig.database,
joinConfig.table,
neededColumn,
joinConfig.filter
)

Copilot uses AI. Check for mistakes.
if (extraDb) {
// Centralized function will handle its own caching
joinedData = await getCachedJoinData(extraDb, joinConfig, neededColumn)
const colInfo = neededColumn ? ` (column: ${neededColumn})` : ''

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable colInfo.

Suggested change
const colInfo = neededColumn ? ` (column: ${neededColumn})` : ''

Copilot uses AI. Check for mistakes.
@tomstephen

Copy link
Copy Markdown
Author

Latest commit partially merges #3, we don't want every change so doing merge manually. Plan going forward is

  • extend sqlite-map with any extra features from POLARIS plugin we want
  • refactor POLARIS plugin to inherit from sqlite-map
  • split out the sql dashboarding features into a separate plugin
  • put together a combined aequilibrae and polaris test

* Extend tile.vue to support hard-coded key-value pairs, sqlite queries for said values, sqlite queries for entire table
* Full SQL support, either individual queries or a full table
* Add usage comment
* Colour palette-ing, defaults to original pastel palette
* Apply suggestions from review
@tomstephen
tomstephen marked this pull request as ready for review January 16, 2026 06:39
@tomstephen
tomstephen merged commit 9fbd3d8 into masterJan 16, 2026
1 check failed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tomstephen
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add AequilibraE support - #1

Merged
tomstephen merged 77 commits into
masterfrom
tom/add-aeq-support
Jan 16, 2026
Merged

Add AequilibraE support#1
tomstephen merged 77 commits into
masterfrom
tom/add-aeq-support

Conversation

@tomstephen

Copy link
Copy Markdown

This PR adds AequilibraE support to SimWrapper. This involves,

  • new plugin at src/plugins/aequilibrae/...
  • registering plugin in src/plugins/pluginRegistry.ts
  • new panel (and registration) in src/dash-panels/aequilibrae.vue (and _allPanels.ts)
  • extension to the HTTPFileSystem.ts to add support for S3 buckets

In my testing I've modified a few other scripts (Splash, deploy scripts, etc) but we don't want to suggest merging these back to the original SimWrapper project, so I will revert. Additionally, current work needs a good refactor, particularly

  • SQLite queries could be leveraged better for speed (for loop over all rows currently)
  • much of the styling/rendering code could be replaced by calls to deck.gl

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 27 changed files in this pull request and generated 25 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

font-size: 1.4rem;
height: 5rem;
font-size: 2.5rem;
// height: 3.5rem;

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commented-out height property on line 318 (// height: 3.5rem;) should either be removed or uncommented if it's needed. Leaving commented code creates maintenance confusion.

Suggested change
// height: 3.5rem;

Copilot uses AI. Check for mistakes.
Comment threadpackage.json Outdated
Comment threadsrc/plugins/aequilibrae/db.ts Outdated
Comment threadsrc/plugins/aequilibrae/AequilibraEReader.vue Outdated
Comment threadsrc/plugins/sqlite-map/styling.ts Outdated
Comment on lines +85 to +113
const buildColorEncoder = (
values: any[],
style: any,
dataRange: [number, number] | null = null
) => {
if (dataRange) {
values = values.map(v => {
const num = toNumber(v)
if (num === null) return null
return Math.max(dataRange[0], Math.min(dataRange[1], num))
})
}

const nums = values.map(toNumber).filter((v): v is number => v !== null)
const s = style || {}
const [min, max] = s.range ? s.range : [safeMin(nums), safeMax(nums)]

const paletteName = s.palette || 'YlGn'
const numColors = s.numColors || 7
const colors = getPaletteColors(paletteName, numColors).map((h: string) => hexToRgba(h, 1))

const scale = max === min ? 0 : (numColors - 1) / (max - min)

return (value: any) => {
const num = toNumber(value) ?? min
const idx = Math.round((num - min) * scale)
return colors[Math.max(0, Math.min(numColors - 1, idx))]
}
}

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing input validation: the function buildColorEncoder doesn't validate that the palette name exists in cartoColors before accessing it. If an invalid palette name is provided, getPaletteColors will return an array of gray colors, which may not be the desired behavior. Consider adding validation or a more informative error message.

Copilot uses AI. Check for mistakes.
Comment threadsrc/plugins/aequilibrae/db.ts Outdated
Comment threadsrc/plugins/aequilibrae/useAequilibrae.ts Outdated
Comment on lines +27 to +34
import {
resolvePath,
resolvePaths,
getUsedColumns,
getNeededJoinColumn,
createJoinCacheKey,
hasGeometryColumn,
} from './utils'

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import getUsedColumns.

Copilot uses AI. Check for mistakes.
Comment on lines +257 to +264
// Create a cache key for this specific join query (for logging only)
const cacheKey = createJoinCacheKey(
joinConfig.database,
joinConfig.table,
neededColumn,
joinConfig.filter
)

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable cacheKey.

Suggested change
// Create a cache key for this specific join query (for logging only)
constcacheKey=createJoinCacheKey(
joinConfig.database,
joinConfig.table,
neededColumn,
joinConfig.filter
)

Copilot uses AI. Check for mistakes.
if (extraDb) {
// Centralized function will handle its own caching
joinedData = await getCachedJoinData(extraDb, joinConfig, neededColumn)
const colInfo = neededColumn ? ` (column: ${neededColumn})` : ''

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable colInfo.

Suggested change
const colInfo = neededColumn ? ` (column: ${neededColumn})` : ''

Copilot uses AI. Check for mistakes.
@tomstephen

Copy link
Copy Markdown
Author

Latest commit partially merges #3, we don't want every change so doing merge manually. Plan going forward is

  • extend sqlite-map with any extra features from POLARIS plugin we want
  • refactor POLARIS plugin to inherit from sqlite-map
  • split out the sql dashboarding features into a separate plugin
  • put together a combined aequilibrae and polaris test

* Extend tile.vue to support hard-coded key-value pairs, sqlite queries for said values, sqlite queries for entire table
* Full SQL support, either individual queries or a full table
* Add usage comment
* Colour palette-ing, defaults to original pastel palette
* Apply suggestions from review
@tomstephen
tomstephen marked this pull request as ready for review January 16, 2026 06:39
@tomstephen
tomstephen merged commit 9fbd3d8 into masterJan 16, 2026
1 check failed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tomstephen
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Add AequilibraE support - #1

Merged
tomstephen merged 77 commits into
masterfrom
tom/add-aeq-support
Jan 16, 2026
Merged

Add AequilibraE support#1
tomstephen merged 77 commits into
masterfrom
tom/add-aeq-support

Conversation

@tomstephen

Copy link
Copy Markdown

This PR adds AequilibraE support to SimWrapper. This involves,

  • new plugin at src/plugins/aequilibrae/...
  • registering plugin in src/plugins/pluginRegistry.ts
  • new panel (and registration) in src/dash-panels/aequilibrae.vue (and _allPanels.ts)
  • extension to the HTTPFileSystem.ts to add support for S3 buckets

In my testing I've modified a few other scripts (Splash, deploy scripts, etc) but we don't want to suggest merging these back to the original SimWrapper project, so I will revert. Additionally, current work needs a good refactor, particularly

  • SQLite queries could be leveraged better for speed (for loop over all rows currently)
  • much of the styling/rendering code could be replaced by calls to deck.gl

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 27 changed files in this pull request and generated 25 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

font-size: 1.4rem;
height: 5rem;
font-size: 2.5rem;
// height: 3.5rem;

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commented-out height property on line 318 (// height: 3.5rem;) should either be removed or uncommented if it's needed. Leaving commented code creates maintenance confusion.

Suggested change
// height: 3.5rem;

Copilot uses AI. Check for mistakes.
Comment threadpackage.json Outdated
Comment threadsrc/plugins/aequilibrae/db.ts Outdated
Comment threadsrc/plugins/aequilibrae/AequilibraEReader.vue Outdated
Comment threadsrc/plugins/sqlite-map/styling.ts Outdated
Comment on lines +85 to +113
const buildColorEncoder = (
values: any[],
style: any,
dataRange: [number, number] | null = null
) => {
if (dataRange) {
values = values.map(v => {
const num = toNumber(v)
if (num === null) return null
return Math.max(dataRange[0], Math.min(dataRange[1], num))
})
}

const nums = values.map(toNumber).filter((v): v is number => v !== null)
const s = style || {}
const [min, max] = s.range ? s.range : [safeMin(nums), safeMax(nums)]

const paletteName = s.palette || 'YlGn'
const numColors = s.numColors || 7
const colors = getPaletteColors(paletteName, numColors).map((h: string) => hexToRgba(h, 1))

const scale = max === min ? 0 : (numColors - 1) / (max - min)

return (value: any) => {
const num = toNumber(value) ?? min
const idx = Math.round((num - min) * scale)
return colors[Math.max(0, Math.min(numColors - 1, idx))]
}
}

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing input validation: the function buildColorEncoder doesn't validate that the palette name exists in cartoColors before accessing it. If an invalid palette name is provided, getPaletteColors will return an array of gray colors, which may not be the desired behavior. Consider adding validation or a more informative error message.

Copilot uses AI. Check for mistakes.
Comment threadsrc/plugins/aequilibrae/db.ts Outdated
Comment threadsrc/plugins/aequilibrae/useAequilibrae.ts Outdated
Comment on lines +27 to +34
import {
resolvePath,
resolvePaths,
getUsedColumns,
getNeededJoinColumn,
createJoinCacheKey,
hasGeometryColumn,
} from './utils'

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import getUsedColumns.

Copilot uses AI. Check for mistakes.
Comment on lines +257 to +264
// Create a cache key for this specific join query (for logging only)
const cacheKey = createJoinCacheKey(
joinConfig.database,
joinConfig.table,
neededColumn,
joinConfig.filter
)

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable cacheKey.

Suggested change
// Create a cache key for this specific join query (for logging only)
constcacheKey=createJoinCacheKey(
joinConfig.database,
joinConfig.table,
neededColumn,
joinConfig.filter
)

Copilot uses AI. Check for mistakes.
if (extraDb) {
// Centralized function will handle its own caching
joinedData = await getCachedJoinData(extraDb, joinConfig, neededColumn)
const colInfo = neededColumn ? ` (column: ${neededColumn})` : ''

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable colInfo.

Suggested change
const colInfo = neededColumn ? ` (column: ${neededColumn})` : ''

Copilot uses AI. Check for mistakes.
@tomstephen

Copy link
Copy Markdown
Author

Latest commit partially merges #3, we don't want every change so doing merge manually. Plan going forward is

  • extend sqlite-map with any extra features from POLARIS plugin we want
  • refactor POLARIS plugin to inherit from sqlite-map
  • split out the sql dashboarding features into a separate plugin
  • put together a combined aequilibrae and polaris test

* Extend tile.vue to support hard-coded key-value pairs, sqlite queries for said values, sqlite queries for entire table
* Full SQL support, either individual queries or a full table
* Add usage comment
* Colour palette-ing, defaults to original pastel palette
* Apply suggestions from review
@tomstephen
tomstephen marked this pull request as ready for review January 16, 2026 06:39
@tomstephen
tomstephen merged commit 9fbd3d8 into masterJan 16, 2026
1 check failed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tomstephen
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add AequilibraE support - #1

Merged
tomstephen merged 77 commits into
masterfrom
tom/add-aeq-support
Jan 16, 2026
Merged

Add AequilibraE support#1
tomstephen merged 77 commits into
masterfrom
tom/add-aeq-support

Conversation

@tomstephen

Copy link
Copy Markdown

This PR adds AequilibraE support to SimWrapper. This involves,

  • new plugin at src/plugins/aequilibrae/...
  • registering plugin in src/plugins/pluginRegistry.ts
  • new panel (and registration) in src/dash-panels/aequilibrae.vue (and _allPanels.ts)
  • extension to the HTTPFileSystem.ts to add support for S3 buckets

In my testing I've modified a few other scripts (Splash, deploy scripts, etc) but we don't want to suggest merging these back to the original SimWrapper project, so I will revert. Additionally, current work needs a good refactor, particularly

  • SQLite queries could be leveraged better for speed (for loop over all rows currently)
  • much of the styling/rendering code could be replaced by calls to deck.gl

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 27 changed files in this pull request and generated 25 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

font-size: 1.4rem;
height: 5rem;
font-size: 2.5rem;
// height: 3.5rem;

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commented-out height property on line 318 (// height: 3.5rem;) should either be removed or uncommented if it's needed. Leaving commented code creates maintenance confusion.

Suggested change
// height: 3.5rem;

Copilot uses AI. Check for mistakes.
Comment threadpackage.json Outdated
Comment threadsrc/plugins/aequilibrae/db.ts Outdated
Comment threadsrc/plugins/aequilibrae/AequilibraEReader.vue Outdated
Comment threadsrc/plugins/sqlite-map/styling.ts Outdated
Comment on lines +85 to +113
const buildColorEncoder = (
values: any[],
style: any,
dataRange: [number, number] | null = null
) => {
if (dataRange) {
values = values.map(v => {
const num = toNumber(v)
if (num === null) return null
return Math.max(dataRange[0], Math.min(dataRange[1], num))
})
}

const nums = values.map(toNumber).filter((v): v is number => v !== null)
const s = style || {}
const [min, max] = s.range ? s.range : [safeMin(nums), safeMax(nums)]

const paletteName = s.palette || 'YlGn'
const numColors = s.numColors || 7
const colors = getPaletteColors(paletteName, numColors).map((h: string) => hexToRgba(h, 1))

const scale = max === min ? 0 : (numColors - 1) / (max - min)

return (value: any) => {
const num = toNumber(value) ?? min
const idx = Math.round((num - min) * scale)
return colors[Math.max(0, Math.min(numColors - 1, idx))]
}
}

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing input validation: the function buildColorEncoder doesn't validate that the palette name exists in cartoColors before accessing it. If an invalid palette name is provided, getPaletteColors will return an array of gray colors, which may not be the desired behavior. Consider adding validation or a more informative error message.

Copilot uses AI. Check for mistakes.
Comment threadsrc/plugins/aequilibrae/db.ts Outdated
Comment threadsrc/plugins/aequilibrae/useAequilibrae.ts Outdated
Comment on lines +27 to +34
import {
resolvePath,
resolvePaths,
getUsedColumns,
getNeededJoinColumn,
createJoinCacheKey,
hasGeometryColumn,
} from './utils'

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import getUsedColumns.

Copilot uses AI. Check for mistakes.
Comment on lines +257 to +264
// Create a cache key for this specific join query (for logging only)
const cacheKey = createJoinCacheKey(
joinConfig.database,
joinConfig.table,
neededColumn,
joinConfig.filter
)

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable cacheKey.

Suggested change
// Create a cache key for this specific join query (for logging only)
constcacheKey=createJoinCacheKey(
joinConfig.database,
joinConfig.table,
neededColumn,
joinConfig.filter
)

Copilot uses AI. Check for mistakes.
if (extraDb) {
// Centralized function will handle its own caching
joinedData = await getCachedJoinData(extraDb, joinConfig, neededColumn)
const colInfo = neededColumn ? ` (column: ${neededColumn})` : ''

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable colInfo.

Suggested change
const colInfo = neededColumn ? ` (column: ${neededColumn})` : ''

Copilot uses AI. Check for mistakes.
@tomstephen

Copy link
Copy Markdown
Author

Latest commit partially merges #3, we don't want every change so doing merge manually. Plan going forward is

  • extend sqlite-map with any extra features from POLARIS plugin we want
  • refactor POLARIS plugin to inherit from sqlite-map
  • split out the sql dashboarding features into a separate plugin
  • put together a combined aequilibrae and polaris test

* Extend tile.vue to support hard-coded key-value pairs, sqlite queries for said values, sqlite queries for entire table
* Full SQL support, either individual queries or a full table
* Add usage comment
* Colour palette-ing, defaults to original pastel palette
* Apply suggestions from review
@tomstephen
tomstephen marked this pull request as ready for review January 16, 2026 06:39
@tomstephen
tomstephen merged commit 9fbd3d8 into masterJan 16, 2026
1 check failed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tomstephen
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add AequilibraE support - #1

Merged
tomstephen merged 77 commits into
masterfrom
tom/add-aeq-support
Jan 16, 2026
Merged

Add AequilibraE support#1
tomstephen merged 77 commits into
masterfrom
tom/add-aeq-support

Conversation

@tomstephen

Copy link
Copy Markdown

This PR adds AequilibraE support to SimWrapper. This involves,

  • new plugin at src/plugins/aequilibrae/...
  • registering plugin in src/plugins/pluginRegistry.ts
  • new panel (and registration) in src/dash-panels/aequilibrae.vue (and _allPanels.ts)
  • extension to the HTTPFileSystem.ts to add support for S3 buckets

In my testing I've modified a few other scripts (Splash, deploy scripts, etc) but we don't want to suggest merging these back to the original SimWrapper project, so I will revert. Additionally, current work needs a good refactor, particularly

  • SQLite queries could be leveraged better for speed (for loop over all rows currently)
  • much of the styling/rendering code could be replaced by calls to deck.gl

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 27 changed files in this pull request and generated 25 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

font-size: 1.4rem;
height: 5rem;
font-size: 2.5rem;
// height: 3.5rem;

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commented-out height property on line 318 (// height: 3.5rem;) should either be removed or uncommented if it's needed. Leaving commented code creates maintenance confusion.

Suggested change
// height: 3.5rem;

Copilot uses AI. Check for mistakes.
Comment threadpackage.json Outdated
Comment threadsrc/plugins/aequilibrae/db.ts Outdated
Comment threadsrc/plugins/aequilibrae/AequilibraEReader.vue Outdated
Comment threadsrc/plugins/sqlite-map/styling.ts Outdated
Comment on lines +85 to +113
const buildColorEncoder = (
values: any[],
style: any,
dataRange: [number, number] | null = null
) => {
if (dataRange) {
values = values.map(v => {
const num = toNumber(v)
if (num === null) return null
return Math.max(dataRange[0], Math.min(dataRange[1], num))
})
}

const nums = values.map(toNumber).filter((v): v is number => v !== null)
const s = style || {}
const [min, max] = s.range ? s.range : [safeMin(nums), safeMax(nums)]

const paletteName = s.palette || 'YlGn'
const numColors = s.numColors || 7
const colors = getPaletteColors(paletteName, numColors).map((h: string) => hexToRgba(h, 1))

const scale = max === min ? 0 : (numColors - 1) / (max - min)

return (value: any) => {
const num = toNumber(value) ?? min
const idx = Math.round((num - min) * scale)
return colors[Math.max(0, Math.min(numColors - 1, idx))]
}
}

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing input validation: the function buildColorEncoder doesn't validate that the palette name exists in cartoColors before accessing it. If an invalid palette name is provided, getPaletteColors will return an array of gray colors, which may not be the desired behavior. Consider adding validation or a more informative error message.

Copilot uses AI. Check for mistakes.
Comment threadsrc/plugins/aequilibrae/db.ts Outdated
Comment threadsrc/plugins/aequilibrae/useAequilibrae.ts Outdated
Comment on lines +27 to +34
import {
resolvePath,
resolvePaths,
getUsedColumns,
getNeededJoinColumn,
createJoinCacheKey,
hasGeometryColumn,
} from './utils'

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import getUsedColumns.

Copilot uses AI. Check for mistakes.
Comment on lines +257 to +264
// Create a cache key for this specific join query (for logging only)
const cacheKey = createJoinCacheKey(
joinConfig.database,
joinConfig.table,
neededColumn,
joinConfig.filter
)

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable cacheKey.

Suggested change
// Create a cache key for this specific join query (for logging only)
constcacheKey=createJoinCacheKey(
joinConfig.database,
joinConfig.table,
neededColumn,
joinConfig.filter
)

Copilot uses AI. Check for mistakes.
if (extraDb) {
// Centralized function will handle its own caching
joinedData = await getCachedJoinData(extraDb, joinConfig, neededColumn)
const colInfo = neededColumn ? ` (column: ${neededColumn})` : ''

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable colInfo.

Suggested change
const colInfo = neededColumn ? ` (column: ${neededColumn})` : ''

Copilot uses AI. Check for mistakes.
@tomstephen

Copy link
Copy Markdown
Author

Latest commit partially merges #3, we don't want every change so doing merge manually. Plan going forward is

  • extend sqlite-map with any extra features from POLARIS plugin we want
  • refactor POLARIS plugin to inherit from sqlite-map
  • split out the sql dashboarding features into a separate plugin
  • put together a combined aequilibrae and polaris test

* Extend tile.vue to support hard-coded key-value pairs, sqlite queries for said values, sqlite queries for entire table
* Full SQL support, either individual queries or a full table
* Add usage comment
* Colour palette-ing, defaults to original pastel palette
* Apply suggestions from review
@tomstephen
tomstephen marked this pull request as ready for review January 16, 2026 06:39
@tomstephen
tomstephen merged commit 9fbd3d8 into masterJan 16, 2026
1 check failed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tomstephen
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Add AequilibraE support - #1

Merged
tomstephen merged 77 commits into
masterfrom
tom/add-aeq-support
Jan 16, 2026
Merged

Add AequilibraE support#1
tomstephen merged 77 commits into
masterfrom
tom/add-aeq-support

Conversation

@tomstephen

Copy link
Copy Markdown

This PR adds AequilibraE support to SimWrapper. This involves,

  • new plugin at src/plugins/aequilibrae/...
  • registering plugin in src/plugins/pluginRegistry.ts
  • new panel (and registration) in src/dash-panels/aequilibrae.vue (and _allPanels.ts)
  • extension to the HTTPFileSystem.ts to add support for S3 buckets

In my testing I've modified a few other scripts (Splash, deploy scripts, etc) but we don't want to suggest merging these back to the original SimWrapper project, so I will revert. Additionally, current work needs a good refactor, particularly

  • SQLite queries could be leveraged better for speed (for loop over all rows currently)
  • much of the styling/rendering code could be replaced by calls to deck.gl

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 27 changed files in this pull request and generated 25 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

font-size: 1.4rem;
height: 5rem;
font-size: 2.5rem;
// height: 3.5rem;

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commented-out height property on line 318 (// height: 3.5rem;) should either be removed or uncommented if it's needed. Leaving commented code creates maintenance confusion.

Suggested change
// height: 3.5rem;

Copilot uses AI. Check for mistakes.
Comment threadpackage.json Outdated
Comment threadsrc/plugins/aequilibrae/db.ts Outdated
Comment threadsrc/plugins/aequilibrae/AequilibraEReader.vue Outdated
Comment threadsrc/plugins/sqlite-map/styling.ts Outdated
Comment on lines +85 to +113
const buildColorEncoder = (
values: any[],
style: any,
dataRange: [number, number] | null = null
) => {
if (dataRange) {
values = values.map(v => {
const num = toNumber(v)
if (num === null) return null
return Math.max(dataRange[0], Math.min(dataRange[1], num))
})
}

const nums = values.map(toNumber).filter((v): v is number => v !== null)
const s = style || {}
const [min, max] = s.range ? s.range : [safeMin(nums), safeMax(nums)]

const paletteName = s.palette || 'YlGn'
const numColors = s.numColors || 7
const colors = getPaletteColors(paletteName, numColors).map((h: string) => hexToRgba(h, 1))

const scale = max === min ? 0 : (numColors - 1) / (max - min)

return (value: any) => {
const num = toNumber(value) ?? min
const idx = Math.round((num - min) * scale)
return colors[Math.max(0, Math.min(numColors - 1, idx))]
}
}

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing input validation: the function buildColorEncoder doesn't validate that the palette name exists in cartoColors before accessing it. If an invalid palette name is provided, getPaletteColors will return an array of gray colors, which may not be the desired behavior. Consider adding validation or a more informative error message.

Copilot uses AI. Check for mistakes.
Comment threadsrc/plugins/aequilibrae/db.ts Outdated
Comment threadsrc/plugins/aequilibrae/useAequilibrae.ts Outdated
Comment on lines +27 to +34
import {
resolvePath,
resolvePaths,
getUsedColumns,
getNeededJoinColumn,
createJoinCacheKey,
hasGeometryColumn,
} from './utils'

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import getUsedColumns.

Copilot uses AI. Check for mistakes.
Comment on lines +257 to +264
// Create a cache key for this specific join query (for logging only)
const cacheKey = createJoinCacheKey(
joinConfig.database,
joinConfig.table,
neededColumn,
joinConfig.filter
)

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable cacheKey.

Suggested change
// Create a cache key for this specific join query (for logging only)
constcacheKey=createJoinCacheKey(
joinConfig.database,
joinConfig.table,
neededColumn,
joinConfig.filter
)

Copilot uses AI. Check for mistakes.
if (extraDb) {
// Centralized function will handle its own caching
joinedData = await getCachedJoinData(extraDb, joinConfig, neededColumn)
const colInfo = neededColumn ? ` (column: ${neededColumn})` : ''

CopilotAIJan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable colInfo.

Suggested change
const colInfo = neededColumn ? ` (column: ${neededColumn})` : ''

Copilot uses AI. Check for mistakes.
@tomstephen

Copy link
Copy Markdown
Author

Latest commit partially merges #3, we don't want every change so doing merge manually. Plan going forward is

  • extend sqlite-map with any extra features from POLARIS plugin we want
  • refactor POLARIS plugin to inherit from sqlite-map
  • split out the sql dashboarding features into a separate plugin
  • put together a combined aequilibrae and polaris test

* Extend tile.vue to support hard-coded key-value pairs, sqlite queries for said values, sqlite queries for entire table
* Full SQL support, either individual queries or a full table
* Add usage comment
* Colour palette-ing, defaults to original pastel palette
* Apply suggestions from review
@tomstephen
tomstephen marked this pull request as ready for review January 16, 2026 06:39
@tomstephen
tomstephen merged commit 9fbd3d8 into masterJan 16, 2026
1 check failed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tomstephen